public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: "Bill O'Donnell" <billodo@sgi.com>
To: Christoph Hellwig <hch@lst.de>
Cc: xfs@sgi.com
Subject: Re: [PATCH 5/9] add support for large btree blocks with CRCs and additional RAS information
Date: Tue, 2 Dec 2008 19:28:59 -0600	[thread overview]
Message-ID: <20081203012859.GA16811@sgi.com> (raw)
In-Reply-To: <20080925225633.GF9822@lst.de>

On Fri, Sep 26, 2008 at 12:56:33AM +0200, Christoph Hellwig wrote:
| Add support for larger btree blocks that contains a CRC32C checksum, a
| filesystem uuid and block number for detecting filesystem consistency
| and out of place writes.  The use of these blocks is triggered by the
| crc superblock patches just added.
| 
| Note that we currently do not log the crc of the block, but re-created
| it during log recovery.  With the pending patch to also checksum the log
| this should be safe against filesystem corruption but doesn't really
| follow the end to end argument.  Also poking into the buffer to find
| out whether this is a btree buffer during log recovery is not a very
| clean way to implement this.  I'll look into how well adding crcs
| to the buffer log items for every btree is going to work and hope
| I can switch to that variant for the next version.

looks good... will need to put this through the QA wringer.


-- 
Bill O'Donnell
SGI
billodo@sgi.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      reply	other threads:[~2008-12-03  1:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-25 22:56 [PATCH 5/9] add support for large btree blocks with CRCs and additional RAS information Christoph Hellwig
2008-12-03  1:28 ` Bill O'Donnell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081203012859.GA16811@sgi.com \
    --to=billodo@sgi.com \
    --cc=hch@lst.de \
    --cc=xfs@sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox