From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id mB32GjCJ005795 for ; Tue, 2 Dec 2008 20:16:45 -0600 Received: from ipmail05.adl2.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 249D41665633 for ; Tue, 2 Dec 2008 18:16:44 -0800 (PST) Received: from ipmail05.adl2.internode.on.net (ipmail05.adl2.internode.on.net [203.16.214.145]) by cuda.sgi.com with ESMTP id MnMvtseSVj5iZGxz for ; Tue, 02 Dec 2008 18:16:44 -0800 (PST) Date: Wed, 3 Dec 2008 13:11:02 +1100 From: Dave Chinner Subject: Re: [patch 02/22] remove useless mnt_want_write call in xfs_write Message-ID: <20081203021102.GA18236@disturbed> References: <20081202160430.775774000@bombadil.infradead.org> <20081202160649.790190000@bombadil.infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20081202160649.790190000@bombadil.infradead.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: xfs@oss.sgi.com On Tue, Dec 02, 2008 at 11:04:32AM -0500, Christoph Hellwig wrote: > > When mnt_want_write was introduced a call to it was added around > xfs_ichgtime, but there is no need for this because a file can't be open > read/write on a r/o mount, and a mount can't degrade r/o while we still > have files open for writing. As the mnt_want_write changes were never > merged into the CVS tree this patch is for mainline only. > > > Signed-off-by: Christoph Hellwig Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs