Re: [patch 20/22] move vn_iowait / vn_iowake into xfs_aops.c

Christoph Hellwig
2008-12-03T10:59:02Z

On Wed, Dec 03, 2008 at 02:17:19PM +1100, Dave Chinner wrote:
> On Tue, Dec 02, 2008 at 11:04:50AM -0500, Christoph Hellwig wrote:
> > The whole machinery to wait on I/O completion is related to the I/O path
> > and should be there instead of in xfs_vnode.c. Also give the functions
> > more descriptive names.
>
> I'm not sure that "xfs_ioend_..." is the best name - it looks
> slightly weird in some of the callers' contexts. Just dropping the
> "end" out of the names makes the code read much better (i.e.
> xfs_io_wait() and xfs_io_wake()). Not particularly important,
> though, and everything else looks good.

xfs_ioend_* wasn't my first choice either. I first did
xfs_iowait/xfs_iowake, but that clashes with the buffercache. And
having names just different by an underscore doesn't seem good either.

Any other suggestions?