Re: [patch 20/22] move vn_iowait / vn_iowake into xfs_aops.c

Dave Chinner
2008-12-03T03:17:29Z

On Tue, Dec 02, 2008 at 11:04:50AM -0500, Christoph Hellwig wrote:
> The whole machinery to wait on I/O completion is related to the I/O path
> and should be there instead of in xfs_vnode.c. Also give the functions
> more descriptive names.

I'm not sure that "xfs_ioend_..." is the best name - it looks
slightly weird in some of the callers' contexts. Just dropping the
"end" out of the names makes the code read much better (i.e.
xfs_io_wait() and xfs_io_wake()). Not particularly important,
though, and everything else looks good.

Reviewed-by: Dave Chinner <david@fromorbit.com>

--
Dave Chinner
david@fromorbit.com