From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id mB32bwj9007258 for ; Tue, 2 Dec 2008 20:37:58 -0600 Received: from ipmail05.adl2.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id C7CB21664C10 for ; Tue, 2 Dec 2008 18:37:56 -0800 (PST) Received: from ipmail05.adl2.internode.on.net (ipmail05.adl2.internode.on.net [203.16.214.145]) by cuda.sgi.com with ESMTP id tjyAnG15L7krGIDY for ; Tue, 02 Dec 2008 18:37:56 -0800 (PST) Date: Wed, 3 Dec 2008 13:37:54 +1100 From: Dave Chinner Subject: Re: [patch 06/22] kill xfs_buf_iostart Message-ID: <20081203023754.GE18236@disturbed> References: <20081202160430.775774000@bombadil.infradead.org> <20081202160650.360918000@bombadil.infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20081202160650.360918000@bombadil.infradead.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: xfs@oss.sgi.com On Tue, Dec 02, 2008 at 11:04:36AM -0500, Christoph Hellwig wrote: > xfs_buf_iostart is a "shared" helper for xfs_buf_read_flags, > xfs_bawrite, and xfs_bdwrite - except that there isn't much shared > code but rather special cases for each caller. > > So remove this function and move the functionality to the caller. > xfs_bawrite and xfs_bdwrite are now big enough to be moved out of > line and the xfs_buf_read_flags is moved into a new helper called > _xfs_buf_read. > > (First sent on August 2nd) > > Signed-off-by: Christoph Hellwig Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs