From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id mB33HSBc010912 for ; Tue, 2 Dec 2008 21:17:29 -0600 Received: from ipmail05.adl2.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id AF98F16220C3 for ; Tue, 2 Dec 2008 19:17:26 -0800 (PST) Received: from ipmail05.adl2.internode.on.net (ipmail05.adl2.internode.on.net [203.16.214.145]) by cuda.sgi.com with ESMTP id VnQxEWwch2ZYldyC for ; Tue, 02 Dec 2008 19:17:26 -0800 (PST) Date: Wed, 3 Dec 2008 14:17:19 +1100 From: Dave Chinner Subject: Re: [patch 20/22] move vn_iowait / vn_iowake into xfs_aops.c Message-ID: <20081203031719.GQ18236@disturbed> References: <20081202160430.775774000@bombadil.infradead.org> <20081202160652.542003000@bombadil.infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20081202160652.542003000@bombadil.infradead.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: xfs@oss.sgi.com On Tue, Dec 02, 2008 at 11:04:50AM -0500, Christoph Hellwig wrote: > The whole machinery to wait on I/O completion is related to the I/O path > and should be there instead of in xfs_vnode.c. Also give the functions > more descriptive names. I'm not sure that "xfs_ioend_..." is the best name - it looks slightly weird in some of the callers' contexts. Just dropping the "end" out of the names makes the code read much better (i.e. xfs_io_wait() and xfs_io_wake()). Not particularly important, though, and everything else looks good. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs