From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: Assertion failed: atomic_read(&mp->m_active_trans)
Date: Thu, 4 Dec 2008 08:39:50 +1100 [thread overview]
Message-ID: <20081203213950.GX18236@disturbed> (raw)
In-Reply-To: <20081203104849.GF15485@infradead.org>
On Wed, Dec 03, 2008 at 05:48:49AM -0500, Christoph Hellwig wrote:
> I'd rather fix it properly.
Sure, but in the mean time, I'd suggest changing it to a WARN_ON()
rather than an ASSERT(). That way we'll continue to have ppl bug us
about it until the VFS can support read-only remounts without racing
correctly.
Has that work been dropped on the floor, Christoph? We've
been holding off removing this ASSERT or adding the hack
I did to work around the common case of the assert triggering
based on the fact that the problem in the VFS would be fixed
in the next release. That was the case each release since
2.6.25 and there doesn't seem to be much progress...
> Do you guys have a somewhat reliable
> testcase hitting it?
I used to have one of the xfsqa tests hit it every so often,
but not what you'd call reliably....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2008-12-03 21:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-25 8:00 Assertion failed: atomic_read(&mp->m_active_trans) Donald Douwsma
2008-12-02 3:25 ` Lachlan McIlroy
2008-12-03 10:48 ` Christoph Hellwig
2008-12-03 21:39 ` Dave Chinner [this message]
2008-12-04 5:36 ` Donald Douwsma
2008-12-04 12:33 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081203213950.GX18236@disturbed \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox