From: Christoph Hellwig <hch@infradead.org>
To: Lachlan McIlroy <lachlan@sgi.com>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] Use the incore inode size in xfs_file_readdir()
Date: Thu, 4 Dec 2008 02:08:27 -0500 [thread overview]
Message-ID: <20081204070827.GB29531@infradead.org> (raw)
In-Reply-To: <49377FBC.5020501@sgi.com>
On Thu, Dec 04, 2008 at 05:59:08PM +1100, Lachlan McIlroy wrote:
> We should be using the incore inode size here not the linux inode
> size. The incore inode size is always up to date for directories
> whereas the linux inode size is not updated for directories.
>
> We've hit assertions in xfs_bmap() and traced it back to the linux
> inode size being zero here but the incore size being correct.
Heh. Looks good, but you can still call ->readdir with a 0 inode size,
so you might want to check for that (actualyl I think other pathes
are goign to take care of it, but..)
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2008-12-04 7:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-04 6:59 [PATCH] Use the incore inode size in xfs_file_readdir() Lachlan McIlroy
2008-12-04 7:08 ` Christoph Hellwig [this message]
2008-12-05 3:22 ` Lachlan McIlroy
2008-12-17 14:20 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081204070827.GB29531@infradead.org \
--to=hch@infradead.org \
--cc=lachlan@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox