From: Christoph Hellwig <hch@infradead.org>
To: Lachlan McIlroy <lachlan@sgi.com>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] Remove unnecessary assertion
Date: Thu, 4 Dec 2008 02:08:50 -0500 [thread overview]
Message-ID: <20081204070850.GC29531@infradead.org> (raw)
In-Reply-To: <49377863.1070109@sgi.com>
On Thu, Dec 04, 2008 at 05:27:47PM +1100, Lachlan McIlroy wrote:
> Hit this assert because an inode was tagged with XFS_ICI_RECLAIM_TAG but
> not XFS_IRECLAIMABLE|XFS_IRECLAIM. This is because xfs_iget_cache_hit()
> first clears XFS_IRECLAIMABLE and then calls __xfs_inode_clear_reclaim_tag()
> while only holding the pag_ici_lock in read mode so we can race with
> xfs_reclaim_inodes_ag(). Looks like xfs_reclaim_inodes_ag() will do the
> right thing anyway so just remove the assert.
>
> Thanks to Christoph for pointing out where the problem was.
Yeah, given that I ran with this patch for a while you have my ACK for
it.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2008-12-04 7:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-04 6:27 [PATCH] Remove unnecessary assertion Lachlan McIlroy
2008-12-04 7:08 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081204070850.GC29531@infradead.org \
--to=hch@infradead.org \
--cc=lachlan@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox