[PATCH] Remove unnecessary assertion

[PATCH] Remove unnecessary assertion

[Lachlan McIlroy]

Hit this assert because an inode was tagged with XFS_ICI_RECLAIM_TAG but
not XFS_IRECLAIMABLE|XFS_IRECLAIM.  This is because xfs_iget_cache_hit()
first clears XFS_IRECLAIMABLE and then calls __xfs_inode_clear_reclaim_tag()
while only holding the pag_ici_lock in read mode so we can race with
xfs_reclaim_inodes_ag().  Looks like xfs_reclaim_inodes_ag() will do the
right thing anyway so just remove the assert.

Thanks to Christoph for pointing out where the problem was.

--- xfs-fix.orig/fs/xfs/linux-2.6/xfs_sync.c
+++ xfs-fix/fs/xfs/linux-2.6/xfs_sync.c
@@ -707,8 +707,6 @@ restart:
  			break;
  		}

-		ASSERT(xfs_iflags_test(ip, (XFS_IRECLAIMABLE|XFS_IRECLAIM)));
-
  		/* ignore if already under reclaim */
  		if (xfs_iflags_test(ip, XFS_IRECLAIM)) {
  			read_unlock(&pag->pag_ici_lock);

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] Remove unnecessary assertion

[Christoph Hellwig]

On Thu, Dec 04, 2008 at 05:27:47PM +1100, Lachlan McIlroy wrote:
> Hit this assert because an inode was tagged with XFS_ICI_RECLAIM_TAG but
> not XFS_IRECLAIMABLE|XFS_IRECLAIM.  This is because xfs_iget_cache_hit()
> first clears XFS_IRECLAIMABLE and then calls __xfs_inode_clear_reclaim_tag()
> while only holding the pag_ici_lock in read mode so we can race with
> xfs_reclaim_inodes_ag().  Looks like xfs_reclaim_inodes_ag() will do the
> right thing anyway so just remove the assert.
> 
> Thanks to Christoph for pointing out where the problem was.

Yeah, given that I ran with this patch for a while you have my ACK for
it.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs