From: Christoph Hellwig <hch@infradead.org>
To: Christoph Hellwig <hch@infradead.org>,
Lachlan McIlroy <lachlan@sgi.com>,
xfs@oss.sgi.com
Subject: Re: Assertion failed: atomic_read(&mp->m_active_trans)
Date: Thu, 4 Dec 2008 07:33:46 -0500 [thread overview]
Message-ID: <20081204123346.GA7085@infradead.org> (raw)
In-Reply-To: <20081203213950.GX18236@disturbed>
On Thu, Dec 04, 2008 at 08:39:50AM +1100, Dave Chinner wrote:
> On Wed, Dec 03, 2008 at 05:48:49AM -0500, Christoph Hellwig wrote:
> > I'd rather fix it properly.
>
> Sure, but in the mean time, I'd suggest changing it to a WARN_ON()
> rather than an ASSERT(). That way we'll continue to have ppl bug us
> about it until the VFS can support read-only remounts without racing
> correctly.
Makes sense.
> Has that work been dropped on the floor, Christoph? We've
> been holding off removing this ASSERT or adding the hack
> I did to work around the common case of the assert triggering
> based on the fact that the problem in the VFS would be fixed
> in the next release. That was the case each release since
> 2.6.25 and there doesn't seem to be much progress...
Yeah, once we got the r/o bind mounts which introduces the
infrastructure to deal with people dropped that ball and we never fixed
it. But I just heard from Al that he's looking into some major surgery
for the remount path, which should include this in the second or third
batch.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2008-12-04 12:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-25 8:00 Assertion failed: atomic_read(&mp->m_active_trans) Donald Douwsma
2008-12-02 3:25 ` Lachlan McIlroy
2008-12-03 10:48 ` Christoph Hellwig
2008-12-03 21:39 ` Dave Chinner
2008-12-04 5:36 ` Donald Douwsma
2008-12-04 12:33 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081204123346.GA7085@infradead.org \
--to=hch@infradead.org \
--cc=lachlan@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox