Re: [patch 07/22] stop using igrab in xfs_vn_link

Dave Chinner
2008-12-03T02:39:52Z

On Tue, Dec 02, 2008 at 11:04:37AM -0500, Christoph Hellwig wrote:
> ->link is guranteed to get an already reference inode passed so we
> can do a simple increment of i_count instead of using igrab and thus
> avoid banging on the global inode_lock. This is what most filesystems
> already do.
>
> Also move the increment after the call to xfs_link to simplify error
> handling.
>
> (First sent on July 26th)
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Reviewed-by: Dave Chinner <david@fromorbit.com>

--
Dave Chinner
david@fromorbit.com