* [PATCH] fix up xfs-cmds build after the parallel-fest
@ 2008-12-05 17:30 Eric Sandeen
2008-12-05 17:37 ` Christoph Hellwig
0 siblings, 1 reply; 4+ messages in thread
From: Eric Sandeen @ 2008-12-05 17:30 UTC (permalink / raw)
To: xfs mailing list
My big parallel build patch lost the "make configure" target.
This broke Makepkgs...
Now, IMHO, running configure from make is a little bass-ackwards;
I'd probably prefer to have Makepkgs explicitly run:
autoconf; configure --myoptions; make
but for now, this adds back in a workable "make configure" target.
Also fixed "make install-lib" for acl, which was failing
in the man subdir.
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Index: xfs-cmds/acl/Makefile
===================================================================
--- xfs-cmds.orig/acl/Makefile 2008-12-05 10:42:40.000000000 -0600
+++ xfs-cmds/acl/Makefile 2008-12-05 10:46:04.977513746 -0600
@@ -38,7 +38,7 @@ else
clean: # if configure hasn't run, nothing to clean
endif
-include/builddefs:
+configure include/builddefs:
autoconf
./configure \
--prefix=/ \
Index: xfs-cmds/acl/man/Makefile
===================================================================
--- xfs-cmds.orig/acl/man/Makefile 2008-12-05 10:42:40.000000000 -0600
+++ xfs-cmds/acl/man/Makefile 2008-12-05 10:48:20.842513303 -0600
@@ -13,10 +13,15 @@ install : $(addsuffix -install,$(SUBDIRS
install-dev : $(addsuffix -install-dev,$(SUBDIRS))
+install-lib: $(addsuffix -install-lib,$(SUBDIRS))
+
%-install:
$(MAKE) -C $* install
%-install-dev:
$(MAKE) -C $* install-dev
+%-install-lib:
+ $(MAKE) -C $* install-lib
+
include $(BUILDRULES)
Index: xfs-cmds/dmapi/Makefile
===================================================================
--- xfs-cmds.orig/dmapi/Makefile 2008-12-05 10:42:40.000000000 -0600
+++ xfs-cmds/dmapi/Makefile 2008-12-05 11:07:59.130513205 -0600
@@ -36,7 +36,7 @@ else
clean: # if configure hasn't run, nothing to clean
endif
-include/builddefs:
+configure include/builddefs:
autoconf
./configure \
--prefix=/ \
Index: xfs-cmds/xfsprogs/Makefile
===================================================================
--- xfs-cmds.orig/xfsprogs/Makefile 2008-12-05 11:08:55.000000000 -0600
+++ xfs-cmds/xfsprogs/Makefile 2008-12-05 11:09:03.698512814 -0600
@@ -44,7 +44,7 @@ else
clean: # if configure hasn't run, nothing to clean
endif
-include/builddefs:
+configure include/builddefs:
autoconf
./configure \
--prefix=/ \
Index: xfs-cmds/xfsdump/Makefile
===================================================================
--- xfs-cmds.orig/xfsdump/Makefile 2008-12-05 10:42:40.000000000 -0600
+++ xfs-cmds/xfsdump/Makefile 2008-12-05 11:12:26.074512652 -0600
@@ -37,7 +37,7 @@ else
clean: # if configure hasn't run, nothing to clean
endif
-include/builddefs:
+configure include/builddefs:
autoconf
./configure \
--prefix=/ \
Index: xfs-cmds/nfs4acl/Makefile
===================================================================
--- xfs-cmds.orig/nfs4acl/Makefile 2008-12-05 10:42:40.000000000 -0600
+++ xfs-cmds/nfs4acl/Makefile 2008-12-05 11:27:54.454512630 -0600
@@ -39,7 +39,7 @@ else
clean: # if configure hasn't run, nothing to clean
endif
-include/builddefs:
+configure include/builddefs:
autoconf
./configure \
--prefix=/ \
Index: xfs-cmds/xfstests/Makefile
===================================================================
--- xfs-cmds.orig/xfstests/Makefile 2008-12-05 10:42:40.000000000 -0600
+++ xfs-cmds/xfstests/Makefile 2008-12-05 11:27:59.947513229 -0600
@@ -42,7 +42,7 @@ else
clean: # if configure hasn't run, nothing to clean
endif
-include/builddefs:
+configure include/builddefs:
autoheader
autoconf
./configure \
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] fix up xfs-cmds build after the parallel-fest
2008-12-05 17:30 [PATCH] fix up xfs-cmds build after the parallel-fest Eric Sandeen
@ 2008-12-05 17:37 ` Christoph Hellwig
2008-12-06 10:24 ` Christoph Hellwig
0 siblings, 1 reply; 4+ messages in thread
From: Christoph Hellwig @ 2008-12-05 17:37 UTC (permalink / raw)
To: Eric Sandeen; +Cc: xfs mailing list
On Fri, Dec 05, 2008 at 11:30:16AM -0600, Eric Sandeen wrote:
> My big parallel build patch lost the "make configure" target.
> This broke Makepkgs...
>
> Now, IMHO, running configure from make is a little bass-ackwards;
> I'd probably prefer to have Makepkgs explicitly run:
>
> autoconf; configure --myoptions; make
>
> but for now, this adds back in a workable "make configure" target.
>
> Also fixed "make install-lib" for acl, which was failing
> in the man subdir.
Thanks, this fixes the dpkg build for me.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] fix up xfs-cmds build after the parallel-fest
2008-12-05 17:37 ` Christoph Hellwig
@ 2008-12-06 10:24 ` Christoph Hellwig
2008-12-06 13:38 ` [PATCH V2] " Eric Sandeen
0 siblings, 1 reply; 4+ messages in thread
From: Christoph Hellwig @ 2008-12-06 10:24 UTC (permalink / raw)
To: Eric Sandeen; +Cc: xfs mailing list
On Fri, Dec 05, 2008 at 12:37:16PM -0500, Christoph Hellwig wrote:
> Thanks, this fixes the dpkg build for me.
But it misses one hunk to fix the attr build, too:
Index: xfs-cmds-git/attr/Makefile
===================================================================
--- xfs-cmds-git.orig/attr/Makefile 2008-12-06 11:20:21.000000000 +0100
+++ xfs-cmds-git/attr/Makefile 2008-12-06 11:20:34.000000000 +0100
@@ -39,7 +39,7 @@ else
clean: # if configure hasn't run, nothing to clean
endif
-include/builddefs:
+configure include/builddefs:
autoconf
./configure \
--prefix=/ \
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH V2] fix up xfs-cmds build after the parallel-fest
2008-12-06 10:24 ` Christoph Hellwig
@ 2008-12-06 13:38 ` Eric Sandeen
0 siblings, 0 replies; 4+ messages in thread
From: Eric Sandeen @ 2008-12-06 13:38 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: xfs mailing list
Christoph Hellwig wrote:
> On Fri, Dec 05, 2008 at 12:37:16PM -0500, Christoph Hellwig wrote:
>
>> Thanks, this fixes the dpkg build for me.
>>
>
> But it misses one hunk to fix the attr build, too:
>
Grr, quilt is nice exept for that pesky quilt add step. :)
================================================================
My big parallel build patch lost the "make configure" target.
This broke Makepkgs...
Now, IMHO, running configure from make is a little bass-ackwards;
I'd probably prefer to have Makepkgs explicitly run:
autoconf; configure --myoptions; make
but for now, this adds back in a workable "make configure" target.
This time, for attr as well!
Also fixed "make install-lib" for acl, which was failing
in the man subdir.
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
---
Index: xfs-cmds/acl/Makefile
===================================================================
--- xfs-cmds.orig/acl/Makefile 2008-12-05 10:42:40.000000000 -0600
+++ xfs-cmds/acl/Makefile 2008-12-05 10:46:04.977513746 -0600
@@ -38,7 +38,7 @@ else
clean: # if configure hasn't run, nothing to clean
endif
-include/builddefs:
+configure include/builddefs:
autoconf
./configure \
--prefix=/ \
Index: xfs-cmds/acl/man/Makefile
===================================================================
--- xfs-cmds.orig/acl/man/Makefile 2008-12-05 10:42:40.000000000 -0600
+++ xfs-cmds/acl/man/Makefile 2008-12-05 10:48:20.842513303 -0600
@@ -13,10 +13,15 @@ install : $(addsuffix -install,$(SUBDIRS
install-dev : $(addsuffix -install-dev,$(SUBDIRS))
+install-lib: $(addsuffix -install-lib,$(SUBDIRS))
+
%-install:
$(MAKE) -C $* install
%-install-dev:
$(MAKE) -C $* install-dev
+%-install-lib:
+ $(MAKE) -C $* install-lib
+
include $(BUILDRULES)
Index: xfs-cmds/attr/Makefile
===================================================================
--- xfs-cmds.orig/attr/Makefile 2008-12-06 07:35:37.000000000 -0600
+++ xfs-cmds/attr/Makefile 2008-12-06 07:35:46.973512932 -0600
@@ -39,7 +39,7 @@ else
clean: # if configure hasn't run, nothing to clean
endif
-include/builddefs:
+configure include/builddefs:
autoconf
./configure \
--prefix=/ \
Index: xfs-cmds/dmapi/Makefile
===================================================================
--- xfs-cmds.orig/dmapi/Makefile 2008-12-06 07:35:27.500512631 -0600
+++ xfs-cmds/dmapi/Makefile 2008-12-06 07:35:51.122575385 -0600
@@ -36,7 +36,7 @@ else
clean: # if configure hasn't run, nothing to clean
endif
-include/builddefs:
+configure include/builddefs:
autoconf
./configure \
--prefix=/ \
Index: xfs-cmds/xfsprogs/Makefile
===================================================================
--- xfs-cmds.orig/xfsprogs/Makefile 2008-12-06 07:35:25.450513137 -0600
+++ xfs-cmds/xfsprogs/Makefile 2008-12-06 07:35:52.019575218 -0600
@@ -44,7 +44,7 @@ else
clean: # if configure hasn't run, nothing to clean
endif
-include/builddefs:
+configure include/builddefs:
autoconf
./configure \
--prefix=/ \
Index: xfs-cmds/xfsdump/Makefile
===================================================================
--- xfs-cmds.orig/xfsdump/Makefile 2008-12-06 07:35:23.576512995 -0600
+++ xfs-cmds/xfsdump/Makefile 2008-12-06 07:35:52.598575866 -0600
@@ -37,7 +37,7 @@ else
clean: # if configure hasn't run, nothing to clean
endif
-include/builddefs:
+configure include/builddefs:
autoconf
./configure \
--prefix=/ \
Index: xfs-cmds/nfs4acl/Makefile
===================================================================
--- xfs-cmds.orig/nfs4acl/Makefile 2008-12-06 07:35:21.142512675 -0600
+++ xfs-cmds/nfs4acl/Makefile 2008-12-06 07:35:53.473513505 -0600
@@ -39,7 +39,7 @@ else
clean: # if configure hasn't run, nothing to clean
endif
-include/builddefs:
+configure include/builddefs:
autoconf
./configure \
--prefix=/ \
Index: xfs-cmds/xfstests/Makefile
===================================================================
--- xfs-cmds.orig/xfstests/Makefile 2008-12-06 07:35:21.141513154 -0600
+++ xfs-cmds/xfstests/Makefile 2008-12-06 07:35:53.473513505 -0600
@@ -42,7 +42,7 @@ else
clean: # if configure hasn't run, nothing to clean
endif
-include/builddefs:
+configure include/builddefs:
autoheader
autoconf
./configure \
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-12-06 13:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-05 17:30 [PATCH] fix up xfs-cmds build after the parallel-fest Eric Sandeen
2008-12-05 17:37 ` Christoph Hellwig
2008-12-06 10:24 ` Christoph Hellwig
2008-12-06 13:38 ` [PATCH V2] " Eric Sandeen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox