From: Christoph Hellwig <hch@infradead.org>
To: Lachlan McIlroy <lachlan@sgi.com>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [RFC, PATCH] XFS_TRANS_DEBUG fixes
Date: Mon, 8 Dec 2008 17:54:26 -0500 [thread overview]
Message-ID: <20081208225426.GA22003@infradead.org> (raw)
In-Reply-To: <4938D3E0.5050501@sgi.com>
On Fri, Dec 05, 2008 at 06:10:24PM +1100, Lachlan McIlroy wrote:
> Some of the things I had to do to get it to work (and could be done some other
> way) are:
> - all buffers that are logged need to be mapped into kernel space so the
> debugging code can make a copy of the buffer data and compare it later.
> The easiest way to do that is to make all buffers mapped in xfs_bug_get_flags()
> when XFS_TRANS_DEBUG is set.
Need a comment similar to this next to the place that sets the flag.
> - Some bit setting functions (btst()/bset()/bfset()) appear to be missing so
> I've coded up some trivial versions. There maybe some linux kernel functions
> that do the same thing.
Just use the Linu set_bit / clear_bit / test_bit / test_and_set_bit /
test_and_clear_bit helpers, or the __ prefixed versions if you don't
need atomicy. Note that they want to have pointers to unsigned long
passed.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2008-12-08 22:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-05 7:10 [RFC, PATCH] XFS_TRANS_DEBUG fixes Lachlan McIlroy
2008-12-08 22:54 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081208225426.GA22003@infradead.org \
--to=hch@infradead.org \
--cc=lachlan@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox