From: Arkadiusz Miskiewicz <arekm@maven.pl>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-xfs@oss.sgi.com
Subject: Re: [PATCH 1/1] Include ctype.h for tolower(3).
Date: Mon, 15 Dec 2008 23:05:21 +0100 [thread overview]
Message-ID: <200812152305.22056.arekm@maven.pl> (raw)
In-Reply-To: <20081215214438.GA5392@infradead.org>
On Monday 15 of December 2008, Christoph Hellwig wrote:
> On Mon, Dec 15, 2008 at 08:59:00PM +0100, Arkadiusz Miskiewicz wrote:
> > ---
> > xfsprogs/libxfs/xfs_dir2.c | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/xfsprogs/libxfs/xfs_dir2.c b/xfsprogs/libxfs/xfs_dir2.c
> > index 71134f8..eab4718 100644
> > --- a/xfsprogs/libxfs/xfs_dir2.c
> > +++ b/xfsprogs/libxfs/xfs_dir2.c
> > @@ -17,6 +17,7 @@
> > */
> >
> > #include <xfs.h>
> > +#include <ctype.h>
>
> This file is shared with the kernel, so adding the include here is not
> a good idea. Can you resubmit it with the include added in
> include/platform_defs.h.in?
Please ignore this patch then. master already has ctype.h in
platform_defs.h.in.
--
Arkadiusz Miśkiewicz PLD/Linux Team
arekm / maven.pl http://ftp.pld-linux.org/
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2008-12-15 22:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-15 19:59 [PATCH 1/1] Include ctype.h for tolower(3) Arkadiusz Miskiewicz
2008-12-15 21:44 ` Christoph Hellwig
2008-12-15 22:05 ` Arkadiusz Miskiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812152305.22056.arekm@maven.pl \
--to=arekm@maven.pl \
--cc=hch@infradead.org \
--cc=linux-xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox