* [PATCH 1/1] Include ctype.h for tolower(3).
@ 2008-12-15 19:59 Arkadiusz Miskiewicz
2008-12-15 21:44 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Arkadiusz Miskiewicz @ 2008-12-15 19:59 UTC (permalink / raw)
To: linux-xfs
---
xfsprogs/libxfs/xfs_dir2.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/xfsprogs/libxfs/xfs_dir2.c b/xfsprogs/libxfs/xfs_dir2.c
index 71134f8..eab4718 100644
--- a/xfsprogs/libxfs/xfs_dir2.c
+++ b/xfsprogs/libxfs/xfs_dir2.c
@@ -17,6 +17,7 @@
*/
#include <xfs.h>
+#include <ctype.h>
struct xfs_name xfs_name_dotdot = {"..", 2};
--
1.6.0.5
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] Include ctype.h for tolower(3).
2008-12-15 19:59 [PATCH 1/1] Include ctype.h for tolower(3) Arkadiusz Miskiewicz
@ 2008-12-15 21:44 ` Christoph Hellwig
2008-12-15 22:05 ` Arkadiusz Miskiewicz
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2008-12-15 21:44 UTC (permalink / raw)
To: Arkadiusz Miskiewicz; +Cc: linux-xfs
On Mon, Dec 15, 2008 at 08:59:00PM +0100, Arkadiusz Miskiewicz wrote:
> ---
> xfsprogs/libxfs/xfs_dir2.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/xfsprogs/libxfs/xfs_dir2.c b/xfsprogs/libxfs/xfs_dir2.c
> index 71134f8..eab4718 100644
> --- a/xfsprogs/libxfs/xfs_dir2.c
> +++ b/xfsprogs/libxfs/xfs_dir2.c
> @@ -17,6 +17,7 @@
> */
>
> #include <xfs.h>
> +#include <ctype.h>
This file is shared with the kernel, so adding the include here is not
a good idea. Can you resubmit it with the include added in
include/platform_defs.h.in?
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] Include ctype.h for tolower(3).
2008-12-15 21:44 ` Christoph Hellwig
@ 2008-12-15 22:05 ` Arkadiusz Miskiewicz
0 siblings, 0 replies; 3+ messages in thread
From: Arkadiusz Miskiewicz @ 2008-12-15 22:05 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: linux-xfs
On Monday 15 of December 2008, Christoph Hellwig wrote:
> On Mon, Dec 15, 2008 at 08:59:00PM +0100, Arkadiusz Miskiewicz wrote:
> > ---
> > xfsprogs/libxfs/xfs_dir2.c | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/xfsprogs/libxfs/xfs_dir2.c b/xfsprogs/libxfs/xfs_dir2.c
> > index 71134f8..eab4718 100644
> > --- a/xfsprogs/libxfs/xfs_dir2.c
> > +++ b/xfsprogs/libxfs/xfs_dir2.c
> > @@ -17,6 +17,7 @@
> > */
> >
> > #include <xfs.h>
> > +#include <ctype.h>
>
> This file is shared with the kernel, so adding the include here is not
> a good idea. Can you resubmit it with the include added in
> include/platform_defs.h.in?
Please ignore this patch then. master already has ctype.h in
platform_defs.h.in.
--
Arkadiusz Miśkiewicz PLD/Linux Team
arekm / maven.pl http://ftp.pld-linux.org/
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-12-15 22:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-15 19:59 [PATCH 1/1] Include ctype.h for tolower(3) Arkadiusz Miskiewicz
2008-12-15 21:44 ` Christoph Hellwig
2008-12-15 22:05 ` Arkadiusz Miskiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox