[PATCH 1/1] Include ctype.h for tolower(3).

[PATCH 1/1] Include ctype.h for tolower(3).

[Arkadiusz Miskiewicz]

---
 xfsprogs/libxfs/xfs_dir2.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/xfsprogs/libxfs/xfs_dir2.c b/xfsprogs/libxfs/xfs_dir2.c
index 71134f8..eab4718 100644
--- a/xfsprogs/libxfs/xfs_dir2.c
+++ b/xfsprogs/libxfs/xfs_dir2.c
@@ -17,6 +17,7 @@
  */
 
 #include <xfs.h>
+#include <ctype.h>
 
 struct xfs_name xfs_name_dotdot = {"..", 2};
 
-- 
1.6.0.5

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH 1/1] Include ctype.h for tolower(3).

[Christoph Hellwig]

On Mon, Dec 15, 2008 at 08:59:00PM +0100, Arkadiusz Miskiewicz wrote:
> ---
>  xfsprogs/libxfs/xfs_dir2.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/xfsprogs/libxfs/xfs_dir2.c b/xfsprogs/libxfs/xfs_dir2.c
> index 71134f8..eab4718 100644
> --- a/xfsprogs/libxfs/xfs_dir2.c
> +++ b/xfsprogs/libxfs/xfs_dir2.c
> @@ -17,6 +17,7 @@
>   */
>  
>  #include <xfs.h>
> +#include <ctype.h>

This file is shared with the kernel, so adding the include here is not
a good idea.  Can you resubmit it with the include added in
include/platform_defs.h.in?

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH 1/1] Include ctype.h for tolower(3).

[Arkadiusz Miskiewicz]

On Monday 15 of December 2008, Christoph Hellwig wrote:
> On Mon, Dec 15, 2008 at 08:59:00PM +0100, Arkadiusz Miskiewicz wrote:
> > ---
> >  xfsprogs/libxfs/xfs_dir2.c |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/xfsprogs/libxfs/xfs_dir2.c b/xfsprogs/libxfs/xfs_dir2.c
> > index 71134f8..eab4718 100644
> > --- a/xfsprogs/libxfs/xfs_dir2.c
> > +++ b/xfsprogs/libxfs/xfs_dir2.c
> > @@ -17,6 +17,7 @@
> >   */
> >
> >  #include <xfs.h>
> > +#include <ctype.h>
>
> This file is shared with the kernel, so adding the include here is not
> a good idea.  Can you resubmit it with the include added in
> include/platform_defs.h.in?

Please ignore this patch then. master already has ctype.h in 
platform_defs.h.in.

-- 
Arkadiusz Miśkiewicz        PLD/Linux Team
arekm / maven.pl            http://ftp.pld-linux.org/

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs