From: Christoph Hellwig <hch@infradead.org>
To: Lachlan McIlroy <lachlan@sgi.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] Remove XFS_BUF_SHUT() and friends
Date: Wed, 17 Dec 2008 09:20:40 -0500 [thread overview]
Message-ID: <20081217142040.GB22023@infradead.org> (raw)
In-Reply-To: <4938A58F.6090109@sgi.com>
On Fri, Dec 05, 2008 at 02:52:47PM +1100, Lachlan McIlroy wrote:
> Christoph Hellwig wrote:
> > On Thu, Dec 04, 2008 at 06:27:16PM +1100, Lachlan McIlroy wrote:
> >> Code does nothing so remove it.
> >
> > Looks good to me. Does anyone remember why this flag was set on IRIX?
>
> During a forced shutdown we would go through all incore buffers and mark
> them B_STALE/B_ERROR/B_SHUT and then call biodone() on them. The code in
> xfs_buf_iodone_callbacks() that checks for B_SHUT is to avoid a double
> biodone() I think. We don't have the code in the Linux port that scans
> through all the incore buffers on a forced shutdown but we still have one
> case in xfs_iflush_cluster(). In any case it's not doing anything.
Ok.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2008-12-17 14:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-04 7:27 [PATCH] Remove XFS_BUF_SHUT() and friends Lachlan McIlroy
2008-12-04 13:27 ` Christoph Hellwig
2008-12-05 3:52 ` Lachlan McIlroy
2008-12-17 14:20 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081217142040.GB22023@infradead.org \
--to=hch@infradead.org \
--cc=lachlan@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox