From: Mark Fasheh <mfasheh@suse.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: linux-kernel@vger.kernel.org, joel.becker@oracle.com,
Christoph Hellwig <hch@infradead.org>,
xfs-masters@oss.sgi.com, Al Viro <viro@zeniv.linux.org.uk>,
Ankit Jain <me@ankitjain.org>,
linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com,
ocfs2-devel@oss.oracle.com
Subject: Re: [xfs-masters] [PATCH][RFC] fs: Add new pre-allocation ioctls to vfs for compatibility with legacy xfs ioctls
Date: Wed, 17 Dec 2008 13:15:50 -0800 [thread overview]
Message-ID: <20081217211550.GF8791@wotan.suse.de> (raw)
In-Reply-To: <494969C6.4090500@sandeen.net>
On Wed, Dec 17, 2008 at 03:06:14PM -0600, Eric Sandeen wrote:
> >> There are some things that I'm not sure about:
> >> 1. Should the struct space_resv be exposed to user-space? If not,
> >> then what would be the right place to put it? And the ioctl
> >> definitions?
> >
> > Yes. As far as where to put it, I'm not sure. Maybe falloc.h?
>
> I'd sort of rather not; why should that legacy struct space_resv be
> available in a header... I thought this was for people already using the
> xfs ioctl, in which case they are already using the xfs header... and if
> they want preallocation in any new work, they should use fallocate()
> instead, yes?
Actually, yeah agreed - I take that back. Old users are already getting them
from file system headers, new ones should use fallocate. So there's no need
to expose the ioctls to userspace, at least not if all we're talking about
is the RESVP ioctls.
--Mark
--
Mark Fasheh
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2008-12-17 21:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-15 8:04 [PATCH][RFC] fs: Add new pre-allocation ioctls to vfs for compatibility with legacy xfs ioctls Ankit Jain
2008-12-17 20:28 ` Mark Fasheh
2008-12-17 21:06 ` [xfs-masters] " Eric Sandeen
2008-12-17 21:15 ` Mark Fasheh [this message]
2008-12-18 9:50 ` Ankit Jain
2008-12-18 9:44 ` Ankit Jain
2008-12-18 21:01 ` Ankit Jain
2008-12-18 6:49 ` Felix Blyakher
2008-12-18 9:54 ` Ankit Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081217211550.GF8791@wotan.suse.de \
--to=mfasheh@suse.com \
--cc=hch@infradead.org \
--cc=joel.becker@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@ankitjain.org \
--cc=ocfs2-devel@oss.oracle.com \
--cc=sandeen@sandeen.net \
--cc=viro@zeniv.linux.org.uk \
--cc=xfs-masters@oss.sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox