From: Christoph Hellwig <hch@infradead.org>
To: Lachlan McIlroy <lachlan@sgi.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [Fwd: [PATCH] Fix race in xfs_write() between direct and buffered I/O with DMAPI]
Date: Tue, 23 Dec 2008 03:40:13 -0500 [thread overview]
Message-ID: <20081223084013.GA7604@infradead.org> (raw)
In-Reply-To: <49503378.2080508@sgi.com>
On Tue, Dec 23, 2008 at 11:40:24AM +1100, Lachlan McIlroy wrote:
> Christoph Hellwig wrote:
> > Do you need more input on this one?
>
> Actually I just might. Based on your last reponse I wasn't sure if
> you wanted me to make further changes.
Well, my reponse was that I think we could do it more effecient, but the
patch still looks correct to me.
> Then I got side-tracked wondering
> why we even have the 'goto retry' in the dmapi post event - why retry the
> write if we get ENOSPC when we don't if dmapi is not enabled? Could the
> write get stuck in an infinite loop?
We only retry on ENOSPC if the dmapi nospace even is enabled, or am I
missing something?
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2008-12-23 8:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-04 6:33 [Fwd: [PATCH] Fix race in xfs_write() between direct and buffered I/O with DMAPI] Lachlan McIlroy
2008-12-08 22:51 ` Christoph Hellwig
2008-12-09 5:10 ` Lachlan McIlroy
2008-12-09 9:22 ` Christoph Hellwig
2008-12-22 8:53 ` Christoph Hellwig
2008-12-23 0:40 ` Lachlan McIlroy
2008-12-23 8:40 ` Christoph Hellwig [this message]
2008-12-24 1:10 ` Lachlan McIlroy
2008-12-24 2:10 ` Niv Sardi
2008-12-24 2:23 ` Lachlan McIlroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081223084013.GA7604@infradead.org \
--to=hch@infradead.org \
--cc=lachlan@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox