From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Mike Frysinger <vapier@gentoo.org>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs-cmds: fix parallel installs in include/ dirs
Date: Tue, 30 Dec 2008 07:49:36 -0500 [thread overview]
Message-ID: <20081230124936.GA26322@infradead.org> (raw)
In-Reply-To: <20081230115224.GA24210@infradead.org>
On Tue, Dec 30, 2008 at 06:52:24AM -0500, Christoph Hellwig wrote:
> On Mon, Dec 29, 2008 at 04:19:05PM -0600, Eric Sandeen wrote:
> > This is for http://oss.sgi.com/bugzilla/show_bug.cgi?id=759
> > "fix parallel issue with include/ symlinks"
> >
> > Doing something like "make -j2 install install-dev" would lead
> > to a race of removing & creating symlinks in include/
> >
> > Thanks to Mike for reporting & suggesting the fix.
>
> Looks good and I've put in in my queue.
Actually spoken too soon. This breaks the acl build for me with:
gcc -g -O2 -DNDEBUG -funsigned-char -fno-strict-aliasing -Wall
-DVERSION=\"2.2.47\" -DLOCALEDIR=\"/usr/share/locale\"
-DPACKAGE=\"acl\" -I../include -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64
-include perm_copy.h -c acl_get_fd.c -fPIC -DPIC -o .libs/acl_get_fd.o
acl_get_fd.c:27:24: error: acl/libacl.h: No such file or directory
acl_get_fd.c: In function 'acl_get_fd':
acl_get_fd.c:62: warning: implicit declaration of function
'acl_from_mode'
acl_get_fd.c:62: warning: return makes pointer from integer without a
cast
It looks like the acl link in include/ doesn't get created properly
with this patch.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2008-12-30 12:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-29 22:19 [PATCH] xfs-cmds: fix parallel installs in include/ dirs Eric Sandeen
2008-12-30 11:52 ` Christoph Hellwig
2008-12-30 12:49 ` Christoph Hellwig [this message]
2008-12-30 14:07 ` Mike Frysinger
2008-12-30 17:18 ` Christoph Hellwig
2008-12-30 20:19 ` Mike Frysinger
2008-12-30 20:23 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081230124936.GA26322@infradead.org \
--to=hch@infradead.org \
--cc=sandeen@sandeen.net \
--cc=vapier@gentoo.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox