From: Mike Frysinger <vapier@gentoo.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Eric Sandeen <sandeen@sandeen.net>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs-cmds: fix parallel installs in include/ dirs
Date: Tue, 30 Dec 2008 15:19:41 -0500 [thread overview]
Message-ID: <200812301519.42689.vapier@gentoo.org> (raw)
In-Reply-To: <20081230171825.GA31624@infradead.org>
[-- Attachment #1.1: Type: text/plain, Size: 1617 bytes --]
On Tuesday 30 December 2008 12:18:25 Christoph Hellwig wrote:
> On Tue, Dec 30, 2008 at 09:07:30AM -0500, Mike Frysinger wrote:
> > acl-2.2.47 built fine for me with `./configure && make` and this patch
> > ...
>
> Works now after a make distclean for me.
>
> > that said, if the only purpose of this is to make sure there are symlinks
> > in include/, why not do it at the tail end of configure ? then there
> > will be no weird parallel magic to worry about, and everything will
> > always be available once configure has finished.
>
> I'll leave that to Eric or anyone else who wants to play a build system
> expert on TV :)
it's easy to do, i just dont know how people feel about the idea in general
diff --git a/configure.in b/configure.in
index 3c46c49..d227630 100644
--- a/configure.in
+++ b/configure.in
@@ -27,4 +27,11 @@ AC_MANUAL_FORMAT
AC_FUNC_GCC_VISIBILITY
-AC_OUTPUT(include/builddefs)
+AC_CONFIG_FILES(include/builddefs)
+AC_CONFIG_COMMANDS([include-symlinks], [
+ rm -f include/acl include/sys
+ ln -s . include/acl
+ ln -s . include/sys
+])
+AC_OUTPUT
+
diff --git a/include/Makefile b/include/Makefile
index f2eca14..d606fa2 100644
--- a/include/Makefile
+++ b/include/Makefile
@@ -10,13 +10,10 @@ LSRCFILES = builddefs.in buildmacros buildrules
config.h.in
LDIRT = sys acl
default:
- rm -f sys acl
- $(LN_S) . sys
- $(LN_S) . acl
include $(BUILDRULES)
-install-dev: default
+install-dev:
$(INSTALL) -m 755 -d $(PKG_INC_DIR)
$(INSTALL) -m 755 -d $(PKG_INC_DIR)/sys
$(INSTALL) -m 644 acl.h $(PKG_INC_DIR)/sys/acl.h
-mike
[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 835 bytes --]
[-- Attachment #2: Type: text/plain, Size: 121 bytes --]
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2008-12-30 20:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-29 22:19 [PATCH] xfs-cmds: fix parallel installs in include/ dirs Eric Sandeen
2008-12-30 11:52 ` Christoph Hellwig
2008-12-30 12:49 ` Christoph Hellwig
2008-12-30 14:07 ` Mike Frysinger
2008-12-30 17:18 ` Christoph Hellwig
2008-12-30 20:19 ` Mike Frysinger [this message]
2008-12-30 20:23 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812301519.42689.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=hch@infradead.org \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox