[PATCH] xfsprogs: make install-qa should only install additional headers

[PATCH] xfsprogs: make install-qa should only install additional headers

[Christoph Hellwig]

make install-qa should only install the headers a normal install-dev
doesn't install instead of repeating the whole game.

That way the additional headers for xfsqa can be installed manually
while using dpkg / rpm for the normal package. 


Signed-off-by: Christoph Hellwig <hch@lst.de>

Index: xfsprogs/Makefile
===================================================================
--- xfsprogs/Makefile	2008-12-30 13:03:06.000000000 +0000
+++ xfsprogs/Makefile	2008-12-30 13:03:15.000000000 +0000
@@ -76,7 +76,7 @@
 
 install-dev: default $(addsuffix -install-dev,$(SUBDIRS))
 
-install-qa: install $(addsuffix -install-qa,$(SUBDIRS))
+install-qa: default $(addsuffix -install-qa,$(SUBDIRS))
 
 %-install:
 	$(MAKE) -C $* install
Index: xfsprogs/include/Makefile
===================================================================
--- xfsprogs/include/Makefile	2008-12-30 13:02:05.000000000 +0000
+++ xfsprogs/include/Makefile	2008-12-30 13:02:31.000000000 +0000
@@ -54,5 +54,5 @@
 	$(INSTALL) -m 755 -d $(DK_INC_DIR)
 	$(INSTALL) -m 644 $(DKHFILES) $(DK_INC_DIR)
 
-install-qa: install-dev
+install-qa: default
 	$(INSTALL) -m 644 $(QAHFILES) $(PKG_INC_DIR)
Index: xfsprogs/libdisk/Makefile
===================================================================
--- xfsprogs/libdisk/Makefile	2008-12-30 13:00:53.000000000 +0000
+++ xfsprogs/libdisk/Makefile	2008-12-30 13:01:39.000000000 +0000
@@ -29,4 +29,4 @@
 install-dev: default
 	$(INSTALL_LTLIB_STATIC)
 
-install-qa: install-dev
+install-qa: default
Index: xfsprogs/libhandle/Makefile
===================================================================
--- xfsprogs/libhandle/Makefile	2008-12-30 13:01:09.000000000 +0000
+++ xfsprogs/libhandle/Makefile	2008-12-30 13:01:34.000000000 +0000
@@ -22,4 +22,4 @@
 install-dev: default
 	$(INSTALL_LTLIB_DEV)
 
-install-qa: install-dev
+install-qa: default

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfsprogs: make install-qa should only install additional headers

[Eric Sandeen]

Christoph Hellwig wrote:
> make install-qa should only install the headers a normal install-dev
> doesn't install instead of repeating the whole game.
> 
> That way the additional headers for xfsqa can be installed manually
> while using dpkg / rpm for the normal package. 

This seems mostly ok, but "install-qa" sort of sounds like it should
install the headers you need for qa and it doesn't, it only (now)
installs the extras right...?  By itself it's kind of a useless target
without also running install-dev isn't it?

To be correct, I think install-qa should have install-dev as a prereq.

Maybe do that, and add a new install-qa-only target? :)

> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> 
> Index: xfsprogs/Makefile
> ===================================================================
> --- xfsprogs/Makefile	2008-12-30 13:03:06.000000000 +0000
> +++ xfsprogs/Makefile	2008-12-30 13:03:15.000000000 +0000
> @@ -76,7 +76,7 @@
>  
>  install-dev: default $(addsuffix -install-dev,$(SUBDIRS))
>  
> -install-qa: install $(addsuffix -install-qa,$(SUBDIRS))
> +install-qa: default $(addsuffix -install-qa,$(SUBDIRS))
>  
>  %-install:
>  	$(MAKE) -C $* install
> Index: xfsprogs/include/Makefile
> ===================================================================
> --- xfsprogs/include/Makefile	2008-12-30 13:02:05.000000000 +0000
> +++ xfsprogs/include/Makefile	2008-12-30 13:02:31.000000000 +0000
> @@ -54,5 +54,5 @@
>  	$(INSTALL) -m 755 -d $(DK_INC_DIR)
>  	$(INSTALL) -m 644 $(DKHFILES) $(DK_INC_DIR)
>  
> -install-qa: install-dev
> +install-qa: default
>  	$(INSTALL) -m 644 $(QAHFILES) $(PKG_INC_DIR)
> Index: xfsprogs/libdisk/Makefile
> ===================================================================
> --- xfsprogs/libdisk/Makefile	2008-12-30 13:00:53.000000000 +0000
> +++ xfsprogs/libdisk/Makefile	2008-12-30 13:01:39.000000000 +0000
> @@ -29,4 +29,4 @@
>  install-dev: default
>  	$(INSTALL_LTLIB_STATIC)
>  
> -install-qa: install-dev
> +install-qa: default
> Index: xfsprogs/libhandle/Makefile
> ===================================================================
> --- xfsprogs/libhandle/Makefile	2008-12-30 13:01:09.000000000 +0000
> +++ xfsprogs/libhandle/Makefile	2008-12-30 13:01:34.000000000 +0000
> @@ -22,4 +22,4 @@
>  install-dev: default
>  	$(INSTALL_LTLIB_DEV)
>  
> -install-qa: install-dev
> +install-qa: default
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
> 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs