From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH 1/5] xfstests: fix compiler warnings
Date: Wed, 31 Dec 2008 04:30:09 -0500 [thread overview]
Message-ID: <20081231093009.GA2120@infradead.org> (raw)
In-Reply-To: <495AD1EF.3080109@sandeen.net>
On Tue, Dec 30, 2008 at 07:59:11PM -0600, Eric Sandeen wrote:
> Just in case this gets transplanted outside xfstests, where _GNU_SOURCE
> may not be defined on the make commandline, would it make sense to just
> put this #define inside
>
> #ifndef _GNU_SOURCE?
>
> Just a thought; otherwise looks good to me.
Yeah, we could. OR we could expect people who take it outside add it
manually after some feature is missing as we do for all other programs
in xfsqa :)
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2008-12-31 10:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20081230230810.986105000@bombadil.infradead.org>
2008-12-30 23:08 ` [PATCH 1/5] xfstests: fix compiler warnings Christoph Hellwig
2008-12-31 1:59 ` Eric Sandeen
2008-12-31 9:30 ` Christoph Hellwig [this message]
2008-12-31 12:08 ` Christoph Hellwig
2008-12-30 23:08 ` [PATCH 2/5] xfstests: update for xfs_dinode_core_t removal Christoph Hellwig
2008-12-31 2:08 ` Eric Sandeen
2008-12-30 23:08 ` [PATCH 3/5] xfstests: test 195, add a testcase for the nodump flag Christoph Hellwig
2008-12-31 2:55 ` Eric Sandeen
2008-12-30 23:08 ` [PATCH 4/5] xfstests: test 196, add a testcase for renames across project boundaries Christoph Hellwig
2008-12-31 3:36 ` Eric Sandeen
2008-12-30 23:08 ` [PATCH 5/5] xfstests: test 197, add a testcase for d_off truncation Christoph Hellwig
2008-12-31 4:00 ` Eric Sandeen
2008-12-31 9:31 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081231093009.GA2120@infradead.org \
--to=hch@infradead.org \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox