From: Christoph Hellwig <hch@infradead.org>
To: Mario Becroft <mb@gem.win.co.nz>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: XFS internal error when NFS client accesses nonexistent inode
Date: Thu, 1 Jan 2009 18:20:16 -0500 [thread overview]
Message-ID: <20090101232016.GA4476@infradead.org> (raw)
In-Reply-To: <87ocyqpqhp.fsf@server.ak.quickcircuit.co.nz>
On Fri, Jan 02, 2009 at 12:15:46PM +1300, Mario Becroft wrote:
> Christoph Hellwig <hch@infradead.org> writes:
>
> > Btw, you update /proc/sys/fs/xfs/error_level manually? The corruption
> > test only triggers from a avalue of 5, but 3 is the default.
>
> I was getting:
>
> Dec 31 09:12:46 nfs1 kernel: nfsd: non-standard errno: -117
>
> and in trying to figure out what it meant, I bumped up the XFS debug
> level to 6, which enabled me to see the errors from XFS. Maybe I should
> have just left it alone?
>
> I should have pointed out that when this happened, the filesystem did
> not actually shut down. So it did not cause any real problems. Should it
> have been shutting down?
>
> I was mainly just worried that depending on what data it happened to hit
Looking at the code again there indeed aren't shutdowns, just
stacktraces. So yes, the stacktraces are caused by the higher error
level. With debug kernels it's still a kernel crash though, but no one
should run debug kernels on their production machines.
> when accessing the nonexistent inode, it might screw things up. If I do
> encounter any shutdowns, I will apply the patch you sent through. Thanks
> for the ultra-fast response.
Please try the second patch which I cc'ed you on as it gives back
the correct error code to the nfs clients.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-01-01 23:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-31 14:09 XFS internal error when NFS client accesses nonexistent inode Mario Becroft
2009-01-01 17:14 ` Christoph Hellwig
2009-01-01 17:37 ` Christoph Hellwig
2009-01-01 19:00 ` Christoph Hellwig
2009-01-01 23:15 ` Mario Becroft
2009-01-01 23:20 ` Christoph Hellwig [this message]
2009-01-01 17:17 ` Feature requests, was " Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090101232016.GA4476@infradead.org \
--to=hch@infradead.org \
--cc=mb@gem.win.co.nz \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox