From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] sanity check attr fork size
Date: Mon, 5 Jan 2009 09:40:11 +1100 [thread overview]
Message-ID: <20090104224011.GK10725@disturbed> (raw)
In-Reply-To: <20090104164211.GA15734@infradead.org>
On Sun, Jan 04, 2009 at 11:42:11AM -0500, Christoph Hellwig wrote:
> Recently we have quite a few kerneloops reports about dereferencing a NULL
> if_data in the attribute fork. From looking over the code this can only
> happen if we pass a 0 size argument to xfs_iformat_local. This implies some
> sort of corruption and in fact the only mailinglist report about this from
> earlier this year was after a powerfail presumably on a system with write
> cache and without barriers.
>
> Add a quick sanity check for the attr fork size in xfs_iformat to catch
> these early and without an oops.
Looks sane to me.
Reviewed-by: Dave Chinner <david@fromorbit.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2009-01-04 22:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-04 16:42 [PATCH] sanity check attr fork size Christoph Hellwig
2009-01-04 22:40 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090104224011.GK10725@disturbed \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox