public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] define xfs_ino_t as unsigned long long
Date: Tue, 6 Jan 2009 12:14:14 +1100	[thread overview]
Message-ID: <20090106011414.GB9448@disturbed> (raw)
In-Reply-To: <20090105193129.GA19909@infradead.org>

On Mon, Jan 05, 2009 at 02:31:29PM -0500, Christoph Hellwig wrote:
> That way we can avoid ugly casts when printining it (like the ones
> that show up on powerpc with Linus' current tree).

Is that because ppc uses int-l64.h instead of int-64ll.h and so __64 gets
defined to an unsigned long on that platform?

Whatever the reason, it looks fine to me.

Reviewed-by: Dave Chinner <david@fromorbit.com>

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2009-01-06  1:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-05 19:31 [PATCH] define xfs_ino_t as unsigned long long Christoph Hellwig
2009-01-06  1:14 ` Dave Chinner [this message]
2009-01-06  8:22   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090106011414.GB9448@disturbed \
    --to=david@fromorbit.com \
    --cc=hch@infradead.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox