From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n061EH6r031757 for ; Mon, 5 Jan 2009 19:14:17 -0600 Received: from ipmail05.adl2.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 477E217ACB3F for ; Mon, 5 Jan 2009 17:14:16 -0800 (PST) Received: from ipmail05.adl2.internode.on.net (ipmail05.adl2.internode.on.net [203.16.214.145]) by cuda.sgi.com with ESMTP id hYofAh9g7KhayZNm for ; Mon, 05 Jan 2009 17:14:16 -0800 (PST) Date: Tue, 6 Jan 2009 12:14:14 +1100 From: Dave Chinner Subject: Re: [PATCH] define xfs_ino_t as unsigned long long Message-ID: <20090106011414.GB9448@disturbed> References: <20090105193129.GA19909@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20090105193129.GA19909@infradead.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: xfs@oss.sgi.com On Mon, Jan 05, 2009 at 02:31:29PM -0500, Christoph Hellwig wrote: > That way we can avoid ugly casts when printining it (like the ones > that show up on powerpc with Linus' current tree). Is that because ppc uses int-l64.h instead of int-64ll.h and so __64 gets defined to an unsigned long on that platform? Whatever the reason, it looks fine to me. Reviewed-by: Dave Chinner Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs