[PATCH] define xfs_ino_t as unsigned long long

[PATCH] define xfs_ino_t as unsigned long long

[Christoph Hellwig]

That way we can avoid ugly casts when printining it (like the ones
that show up on powerpc with Linus' current tree).


Signed-off-by: Christoph Hellwig <hch@lst.de>

Index: xfs/fs/xfs/xfs_types.h
===================================================================
--- xfs.orig/fs/xfs/xfs_types.h	2009-01-01 11:53:17.321546620 +0100
+++ xfs/fs/xfs/xfs_types.h	2009-01-05 20:30:04.794549213 +0100
@@ -45,7 +45,7 @@ typedef __uint32_t		prid_t;		/* project 
 typedef __uint32_t		inst_t;		/* an instruction */
 
 typedef __s64			xfs_off_t;	/* <file offset> type */
-typedef __u64			xfs_ino_t;	/* <inode> type */
+typedef unsigned long long	xfs_ino_t;	/* <inode> type */
 typedef __s64			xfs_daddr_t;	/* <disk address> type */
 typedef char *			xfs_caddr_t;	/* <core address> type */
 typedef __u32			xfs_dev_t;

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] define xfs_ino_t as unsigned long long

[Dave Chinner]

On Mon, Jan 05, 2009 at 02:31:29PM -0500, Christoph Hellwig wrote:
> That way we can avoid ugly casts when printining it (like the ones
> that show up on powerpc with Linus' current tree).

Is that because ppc uses int-l64.h instead of int-64ll.h and so __64 gets
defined to an unsigned long on that platform?

Whatever the reason, it looks fine to me.

Reviewed-by: Dave Chinner <david@fromorbit.com>

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] define xfs_ino_t as unsigned long long

[Christoph Hellwig]

On Tue, Jan 06, 2009 at 12:14:14PM +1100, Dave Chinner wrote:
> On Mon, Jan 05, 2009 at 02:31:29PM -0500, Christoph Hellwig wrote:
> > That way we can avoid ugly casts when printining it (like the ones
> > that show up on powerpc with Linus' current tree).
> 
> Is that because ppc uses int-l64.h instead of int-64ll.h and so __64 gets
> defined to an unsigned long on that platform?

Yes.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs