public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: brandon@ifup.org
To: tes@sgi.com
Cc: Brandon Philips <bphilips@suse.de>, xfs@oss.sgi.com
Subject: [patch 1/5] [PATCH] acl: add make test target and use make to run tests
Date: Wed, 07 Jan 2009 17:53:56 -0800	[thread overview]
Message-ID: <20090108015418.504806823@ifup.org> (raw)
In-Reply-To: 20090108015355.613058570@ifup.org

[-- Attachment #1: acl-add-make-test-target-and-use-make-to-run-tests.patch --]
[-- Type: text/plain, Size: 2222 bytes --]

The tests are difficult to run. So, this patch adds a Make target that
sets up the path and runs *.test files in the test/ directory.

nfs specific tests can be ran from the test directory by running
`make nfs`

tests requiring root can be ran from the test directory by running
`make nfs`

Signed-off-by: Brandon Philips <bphilips@suse.de>

---
 Makefile      |    6 +++++-
 test/Makefile |   26 +++++++++++++++++++-------
 2 files changed, 24 insertions(+), 8 deletions(-)

Index: acl-2.2.47/test/Makefile
===================================================================
--- acl-2.2.47.orig/test/Makefile
+++ acl-2.2.47/test/Makefile
@@ -2,13 +2,25 @@
 # Copyright (c) 2001-2002 Silicon Graphics, Inc.  All Rights Reserved.
 #
 
-TOPDIR = ..
-include $(TOPDIR)/include/builddefs
+TEST = $(wildcard *.test)
+ROOT = $(wildcard root/*.test)
+NFS = $(wildcard nfs/*.test)
 
-LSRCFILES = run make-tree \
-	    cp.test getfacl-noacl.test misc.test nfs-dir.test \
-	    nfsacl.test permissions.test setfacl.test
+PATH := $(abspath ../getfacl/):$(abspath ../setfacl/):$(abspath ../chacl/):$(PATH)
 
-include $(BUILDRULES)
+all: $(TEST)
+root: $(ROOT)
+nfs: $(NFS)
 
-default install install-dev install-lib:
+
+$(TEST):
+	@echo "*** $@ ***"; perl run $@
+
+$(NFS):
+	@echo "NFS specific tests"; @echo "*** $@ ***"; perl run $@
+
+$(ROOT):
+	@echo "Note: Tests must run as root"; @echo "*** $@ ***"; perl run $@
+
+.PHONY: $(TEST) $(ROOT) $(NFS) default
+.NOTPARALLEL:
Index: acl-2.2.47/Makefile
===================================================================
--- acl-2.2.47.orig/Makefile
+++ acl-2.2.47/Makefile
@@ -17,7 +17,7 @@ LDIRT = config.log .dep config.status co
 	Logs/* built .census install.* install-dev.* install-lib.* *.gz
 
 SUBDIRS = include libmisc libacl getfacl setfacl chacl m4 man doc po \
-	  test examples build debian
+	  examples build debian
 
 default: $(CONFIGURE)
 ifeq ($(HAVE_BUILDDEFS), no)
@@ -65,3 +65,7 @@ install-lib: default
 realclean distclean: clean
 	rm -f $(LDIRT) $(CONFIGURE)
 	rm -rf autom4te.cache Logs
+
+.PHONY: test
+test: default
+	$(MAKE) -C test/

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2009-01-08  2:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-08  1:53 [patch 0/5] acl: test/ improvements and integrate with make brandon
2009-01-08  1:53 ` brandon [this message]
2009-02-09  1:34   ` [patch 1/5] [PATCH] acl: add make test target and use make to run tests Andreas Gruenbacher
2009-01-08  1:53 ` [patch 2/5] [PATCH] acl: various improvements for test/run brandon
2009-02-09  1:29   ` Andreas Gruenbacher
2009-02-09  4:29     ` Greg Banks
2009-01-08  1:53 ` [patch 3/5] [PATCH] acl: move root tests to their own folder brandon
2009-02-09  1:52   ` Andreas Gruenbacher
2009-01-08  1:53 ` [patch 4/5] [PATCH] acl: move nfs " brandon
2009-02-09  1:51   ` Andreas Gruenbacher
2009-01-08  1:54 ` [patch 5/5] [PATCH] acl: minor fix to cp.test brandon
2009-02-09  1:40   ` Andreas Gruenbacher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090108015418.504806823@ifup.org \
    --to=brandon@ifup.org \
    --cc=bphilips@suse.de \
    --cc=tes@sgi.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox