From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n08MS6TH013091 for ; Thu, 8 Jan 2009 16:28:07 -0600 Received: from ipmail05.adl2.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 8FCE17244C for ; Thu, 8 Jan 2009 14:28:05 -0800 (PST) Received: from ipmail05.adl2.internode.on.net (ipmail05.adl2.internode.on.net [203.16.214.145]) by cuda.sgi.com with ESMTP id h1LthNFHgnpKQeas for ; Thu, 08 Jan 2009 14:28:05 -0800 (PST) Date: Fri, 9 Jan 2009 09:28:00 +1100 From: Dave Chinner Subject: Re: [PATCH] xfsdump support for 64K page size Message-ID: <20090108222800.GG9448@disturbed> References: <4964C5EF.3060308@sgi.com> <4965629C.2000703@sgi.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4965629C.2000703@sgi.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Mark Goodwin Cc: xfs-dev , xfs@oss.sgi.com On Thu, Jan 08, 2009 at 01:19:08PM +1100, Mark Goodwin wrote: > Bill Kendall wrote: > > Various fixes to allow xfsdump/xfsrestore to work with 64K > > page size. This is essentially Chinner's patch from a while > > back. > > > > Signed-off-by: Bill Kendall > > Lachlan reviewed and ack'd this on an internal list and I've committed > it (on Bill's behalf) as follows : > > git://oss.sgi.com/xfs/cmds/xfsdump.git > commit 9502587dbbfdd465958889a568dc2842f10b1ff9 > Author: Mark Goodwin > Date: Thu Jan 8 12:37:53 2009 +1100 > > Various fixes to allow xfsdump/xfsrestore to work with 64K > page size. This is essentially Chinner's patch from a while > back. I guess I don't have a real name ;) BTW, these changes are the *exact* patches I sent back in March. I note that the change logs from those patches have been dropped on the floor. i.e.: http://oss.sgi.com/archives/xfs/2008-05/msg00339.html The extended attr buffer size used by xfsdump is based on page size. The maximum buffer size the kernel will accept is 64k. On a 64k page machine, the default buffer size will be rejected by the kernel, thereby breaking dump and restore. Limit the buffer size to XATTR_LIST_MAX in dump, restore and libhandle so the kernel won't reject otherwise valid requests. ---- http://oss.sgi.com/archives/xfs/2008-05/msg00340.html xfsrestore has assumptions about page size built into the inode hunk size in the dump format. Seems to be a stupid thing to do - this patch simply comments out the asserts to allow it to work on 64k page size machine, but probably subtly breaks the code. Nasty hack, really, but allows xfsqa tests to pass. ---- I'd also like to know what validation has been done of the second patch. e.g. is it going to break when dump and restore are done on machines of different page size? This is why I didn't sign-off on the second patch.... > In any case, Christoph, please pull these commits into your kernel.org > -dev trees. NACK. Lets do a proper review cycle first. Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs