From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 3/3] xfs: make xfs_ino_t an unsigned long long
Date: Fri, 9 Jan 2009 09:44:13 +1100 [thread overview]
Message-ID: <20090108224413.GK9448@disturbed> (raw)
In-Reply-To: <20090108184430.967925000@bombadil.infradead.org>
On Thu, Jan 08, 2009 at 01:42:25PM -0500, Christoph Hellwig wrote:
> Currently xfs_ino_t is defined as a u64 which can either be an unsigned
> long long or on some 64 bit platforms and unsigned long. Just making
> it and unsigned long long mean's it's still always 64 bits wide, but we
> don't need to resort to cases to print it.
>
> Fixes a warning regression on 64 bit powerpc in current git.
>
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Index: xfs/fs/xfs/xfs_types.h
> ===================================================================
> --- xfs.orig/fs/xfs/xfs_types.h 2009-01-01 11:53:17.321546620 +0100
> +++ xfs/fs/xfs/xfs_types.h 2009-01-05 20:30:04.794549213 +0100
> @@ -45,7 +45,7 @@ typedef __uint32_t prid_t; /* project
> typedef __uint32_t inst_t; /* an instruction */
>
> typedef __s64 xfs_off_t; /* <file offset> type */
> -typedef __u64 xfs_ino_t; /* <inode> type */
> +typedef unsigned long long xfs_ino_t; /* <inode> type */
> typedef __s64 xfs_daddr_t; /* <disk address> type */
> typedef char * xfs_caddr_t; /* <core address> type */
> typedef __u32 xfs_dev_t;
Reviewed-by: Dave Chinner <david@fromorbit.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2009-01-08 22:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-08 18:42 [PATCH 0/3] regression fixes for 2.6.29 Christoph Hellwig
2009-01-08 18:42 ` [PATCH 1/3] xfs: fix compile of xfs_btree_readahead_lblock on m68k Christoph Hellwig
2009-01-08 22:42 ` Dave Chinner
2009-01-08 18:42 ` [PATCH 2/3] xfs: truncate readdir offsets to signed 32 bit values Christoph Hellwig
2009-01-08 19:00 ` Christoph Hellwig
2009-01-08 22:43 ` Dave Chinner
2009-01-08 18:42 ` [PATCH 3/3] xfs: make xfs_ino_t an unsigned long long Christoph Hellwig
2009-01-08 22:44 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090108224413.GK9448@disturbed \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox