From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: add test 199, bad_features2 correction
Date: Sat, 10 Jan 2009 15:33:47 -0500 [thread overview]
Message-ID: <20090110203347.GA7733@infradead.org> (raw)
In-Reply-To: <4969053E.2060903@sandeen.net>
On Sat, Jan 10, 2009 at 02:29:50PM -0600, Eric Sandeen wrote:
> Christoph Hellwig wrote:
> > Index: xfstests-dev/199
> > ===================================================================
> > --- /dev/null 1970-01-01 00:00:00.000000000 +0000
> > +++ xfstests-dev/199 2009-01-03 20:36:06.000000000 +0000
> > @@ -0,0 +1,65 @@
> > +#! /bin/sh
> > +# FS QA Test No. 199
> > +#
> > +# Check that a filesystem first mounted read-only and then remounted
> > +# performs the features2 fixup properly.
>
> Seems fine. Would it be worth adding a few more lines to also test that
> a simple rw mount (w/o going through ro first) also properly fixes it?
I was under the impression that we already tested that somewhere else,
but it seems like we don't. Yes, I'll add it, that's a good one.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2009-01-10 23:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-03 20:53 [PATCH] xfstests: add test 199, bad_features2 correction Christoph Hellwig
2009-01-10 20:29 ` Eric Sandeen
2009-01-10 20:33 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090110203347.GA7733@infradead.org \
--to=hch@infradead.org \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox