From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 4/7] xfs: lockdep annotations for xfs_dqlock2
Date: Tue, 13 Jan 2009 10:09:33 +1100 [thread overview]
Message-ID: <20090112230933.GM8071@disturbed> (raw)
In-Reply-To: <20090112151544.GA25507@infradead.org>
On Mon, Jan 12, 2009 at 10:15:44AM -0500, Christoph Hellwig wrote:
> On Mon, Jan 12, 2009 at 10:06:37AM +1100, Dave Chinner wrote:
> > This looks a bit wierd.
> >
> > Yes, xfs_dqlock() is just a wrapper around mutex_lock, but we should
> > be consistent here. Can you add a xfs_dqlock_nested() wrapper to do
> > this?
>
> I don't think we should add more of the silly wrappers. What about
> the version below that always uses plain mutex_lock* in xfs_dqlock2?
Fair enough.
> ---
>
> Subject: xfs: lockdep annotations for xfs_dqlock2
> From: Christoph Hellwig <hch@lst.de>
>
> xfs_dqlock2 locks two xfs_dquots, which is fine as it always locks the
> dquot with the lower id first. Use mutex_lock_nested to tell lockdep
> about this fact. Also clean up xfs_dqlock2 a bit by rationalizing
> the conditionals and always using the mutex_lock family of functions
> directly.
>
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Dave Chinner <david@fromorbit.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-01-12 23:20 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-09 22:11 [PATCH 0/7] Remaining 2.6.29 queue Christoph Hellwig
2009-01-09 22:11 ` [PATCH 1/7] xfs: fix dentry aliasing issues in open_by_handle Christoph Hellwig
2009-01-11 23:33 ` Dave Chinner
2009-01-12 15:39 ` Christoph Hellwig
2009-01-14 1:57 ` Dave Chinner
2009-01-14 7:02 ` Lachlan McIlroy
2009-01-14 22:37 ` Dave Chinner
2009-01-14 22:50 ` Lachlan McIlroy
2009-01-09 22:11 ` [PATCH 2/7] xfs: use mnt_want_write in compat_attrmulti ioctl Christoph Hellwig
2009-01-11 23:08 ` Dave Chinner
2009-01-09 22:11 ` [PATCH 3/7] xfs: add a separate lock class for the per-mount list of dquots Christoph Hellwig
2009-01-11 23:03 ` Dave Chinner
2009-01-09 22:11 ` [PATCH 4/7] xfs: lockdep annotations for xfs_dqlock2 Christoph Hellwig
2009-01-11 23:06 ` Dave Chinner
2009-01-12 15:15 ` Christoph Hellwig
2009-01-12 23:09 ` Dave Chinner [this message]
2009-01-09 22:11 ` [PATCH 5/7] xfs: add a lock class for group/project dquots Christoph Hellwig
2009-01-11 23:07 ` Dave Chinner
2009-01-09 22:11 ` [PATCH 6/7] xfs: fix bad_features2 fixups for the root filesystem Christoph Hellwig
2009-01-11 23:03 ` Dave Chinner
2009-01-09 22:11 ` [PATCH 7/7] xfs: sanity check attr fork size Christoph Hellwig
2009-01-18 17:02 ` [PATCH 0/7] Remaining 2.6.29 queue Christoph Hellwig
2009-01-18 17:22 ` Felix Blyakher
2009-01-19 1:52 ` Lachlan McIlroy
2009-01-19 1:52 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090112230933.GM8071@disturbed \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox