public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Nick Piggin <nickpiggin@yahoo.com.au>,
	Eric Sesterhenn <snakebyte@gmx.de>, Pavel Machek <pavel@suse.cz>,
	Chris Mason <chris.mason@oracle.com>,
	linux-kernel@vger.kernel.org, npiggin@yahoo.com.au,
	xfs@oss.sgi.com
Subject: Re: [PATCH] Re: Corrupted XFS log replay oops.
Date: Thu, 22 Jan 2009 01:11:58 -0500	[thread overview]
Message-ID: <20090122061158.GA31104@infradead.org> (raw)
In-Reply-To: <20090122043747.GU10158@disturbed>

On Thu, Jan 22, 2009 at 03:37:47PM +1100, Dave Chinner wrote:
>  xfs_buf_t *
>  xlog_get_bp(
>  	xlog_t		*log,
> -	int		num_bblks)
> +	int		nbblks)

Any reason for reanming this variable?  That causes quite a bit of
churn.

>  {
> -	ASSERT(num_bblks > 0);
> +	if (nbblks <= 0 || nbblks > log->l_logBBsize) {
> +		xlog_warn("XFS: Invalid block length (0x%x) given for buffer", nbblks);

And doesn't prevent this line from needing a linebreak to stay under 80
characters :)

Except for these nitpicks it looks fine to me.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  parent reply	other threads:[~2009-01-22  6:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20090113142147.GE16333@alice>
     [not found] ` <1231857643.29164.28.camel@think.oraclecorp.com>
     [not found]   ` <20090113144307.GF16333@alice>
     [not found]     ` <20090118174035.GG1944@ucw.cz>
     [not found]       ` <20090120063150.GC5854@alice>
     [not found]         ` <20090120101119.GB10158@disturbed>
     [not found]           ` <20090120101503.GC17377@alice>
     [not found]             ` <20090120125944.GC10158@disturbed>
     [not found]               ` <20090120173455.GC21339@alice>
2009-01-21  3:57                 ` Corrupted XFS log replay oops. (was Re: Warning and BUG with btrfs and corrupted image) Dave Chinner
2009-01-21  4:03                   ` Dave Chinner
     [not found]                   ` <200901211503.07308.nickpiggin@yahoo.com.au>
2009-01-22  4:37                     ` [PATCH] Re: Corrupted XFS log replay oops Dave Chinner
2009-01-22  5:50                       ` Felix Blyakher
2009-01-22  6:11                       ` Christoph Hellwig [this message]
2009-01-22  8:35                         ` Eric Sesterhenn
2009-01-22 10:06                         ` Eric Sesterhenn
2009-01-22 23:37                           ` Dave Chinner
2009-01-23  1:10                             ` Dave Chinner
2009-01-22 23:35                         ` Dave Chinner
2009-01-23  0:02                         ` Dave Chinner
2009-01-23  0:06                           ` Christoph Hellwig
2009-01-23  6:20                             ` Felix Blyakher
2009-02-03 20:48                       ` Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090122061158.GA31104@infradead.org \
    --to=hch@infradead.org \
    --cc=chris.mason@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nickpiggin@yahoo.com.au \
    --cc=npiggin@yahoo.com.au \
    --cc=pavel@suse.cz \
    --cc=snakebyte@gmx.de \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox