From: Christoph Hellwig <hch@infradead.org>
To: Felix Blyakher <felixb@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] [XFS] Warn on transaction in flight on read-only remount
Date: Thu, 22 Jan 2009 01:27:03 -0500 [thread overview]
Message-ID: <20090122062703.GA6873@infradead.org> (raw)
In-Reply-To: <0AC805F5-C30E-4439-A32B-2625D7FBEDFD@sgi.com>
On Thu, Jan 22, 2009 at 12:10:15AM -0600, Felix Blyakher wrote:
> [resending after fixing xfs mailing list on oss]
>
> Just wanted to point out to discussion on this topic:
>
> http://oss.sgi.com/archives/xfs/2008-12/msg00019.html
>
> I merely took a suggestion from it, and put it in a patch.
Did you actually test it? WARN_ON has an inverted sense over
ASSERT/ASSERT_ALWAYS, so this would trigger all the time.
>> + /* Just warn here till VFS can correctly support
>> + * read-only remount without racing.
>> + */
Also this should be:
/*
* ...
I also have a VFS -level patch somewhere to prevent further writers to
occur during a remount in a rather hacky way, but I'd rather have a
testcase to reproduce this reliably before sending it to Al.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-01-22 6:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1232578645-20213-1-git-send-email-felixb@sgi.com>
2009-01-22 6:10 ` [PATCH] [XFS] Warn on transaction in flight on read-only remount Felix Blyakher
2009-01-22 6:27 ` Christoph Hellwig [this message]
2009-01-22 6:34 ` Felix Blyakher
2009-01-23 6:14 Felix Blyakher
2009-01-24 3:43 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090122062703.GA6873@infradead.org \
--to=hch@infradead.org \
--cc=felixb@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox