[PATCH] xfsprogs: update doc/CHANGES

[PATCH] xfsprogs: update doc/CHANGES

[Christoph Hellwig]

Signed-off-by: Christoph Hellwig <hch@lst.de>

Index: xfsprogs-dev/doc/CHANGES
===================================================================
--- xfsprogs-dev.orig/doc/CHANGES	2009-01-23 01:49:25.340595380 +0100
+++ xfsprogs-dev/doc/CHANGES	2009-01-23 01:55:30.661598153 +0100
@@ -1,7 +1,15 @@
 xfsprogs-3.0.0
+	- Various smaller xfs_repair improvements
+	- Various gettext improvements, thanks to Jakub Bogusz
+	- Polish translation update, thanks to Jakub Bogusz
+	- Various xfs_quta fixes, thanks to Arkadiusz Miskiewicz
+	- Support parallel builds
+	- Detection of btrfs, gfs and gfs2 in libdisk
+	- Addition of the xfs_fsr and xfs_estimate tools previous found
+	  in the xfsdump package
 	- Resync libxfs to latest kernel implemenation
 	- Update all of xfsprogs to latest kernel interfaces
-	- Add sparse support to xfsprogs build (thanks to Christoph Hellwig)
+	- Add sparse support to xfsprogs build
 	- Cleanup devel package for xfsctl, libhandle and libdisk only
 	  (remove libxfs interfaces).
 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfsprogs: update doc/CHANGES

[Nathan Scott]

On Thu, 2009-01-22 at 19:56 -0500, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig <hch@lst.de>

> +	- Various xfs_quta fixes, thanks to Arkadiusz Miskiewicz

typo.

> +	- Addition of the xfs_fsr and xfs_estimate tools previous found
> +	  in the xfsdump package

rpm magic is probably needed in build/rpm/rpm.spec.in to prevent
old versions of xfsdump from being installed alongside the new
xfsprogs ... else rpm will report file conflicts, I think?  Same
will be needed in debian/control... hmm, both should be pretty
easy - just change "Conflicts: xfsdump < 2.0.0" to "3.0.0" (and
we should make xfsdump v3 at this time too, so its very clear).

Else, all looks good.

cheers.

--
Nathan

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfsprogs: update doc/CHANGES

[Christoph Hellwig]

On Sat, Jan 24, 2009 at 04:22:58PM +1100, Nathan Scott wrote:
> On Thu, 2009-01-22 at 19:56 -0500, Christoph Hellwig wrote:
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> 
> > +	- Various xfs_quta fixes, thanks to Arkadiusz Miskiewicz
> 
> typo.
> 
> > +	- Addition of the xfs_fsr and xfs_estimate tools previous found
> > +	  in the xfsdump package
> 
> rpm magic is probably needed in build/rpm/rpm.spec.in to prevent
> old versions of xfsdump from being installed alongside the new
> xfsprogs ... else rpm will report file conflicts, I think?  Same
> will be needed in debian/control... hmm, both should be pretty
> easy - just change "Conflicts: xfsdump < 2.0.0" to "3.0.0" (and
> we should make xfsdump v3 at this time too, so its very clear).

Agreed.  I think it's better to leave the debian part to you, and
I'll look into the rpm part later.

Any chance you could also review the fsr and estimate manpage
patches as they should go in before this one?

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfsprogs: update doc/CHANGES

[Nathan Scott]

On Sat, 2009-01-24 at 00:28 -0500, Christoph Hellwig wrote:
> > > +	- Addition of the xfs_fsr and xfs_estimate tools previous found
> > > +	  in the xfsdump package
> > 
> > rpm magic is probably needed in build/rpm/rpm.spec.in to prevent
> > old versions of xfsdump from being installed alongside the new
> > xfsprogs ... else rpm will report file conflicts, I think?  Same
> > will be needed in debian/control... hmm, both should be pretty
> > easy - just change "Conflicts: xfsdump < 2.0.0" to "3.0.0" (and
> > we should make xfsdump v3 at this time too, so its very clear).
> 
> Agreed.  I think it's better to leave the debian part to you, and
> I'll look into the rpm part later.

Both files just need the above-mentioned change.  I'll send a
patch.

> Any chance you could also review the fsr and estimate manpage
> patches as they should go in before this one?

No worries - the estimate man page move looks fine (as long as
its also removed from xfsdump package, of course).

+//#include "config.h"
shouldn't be there in the final fsr checkin I guess - there is
no config.h in xfsprogs.

> +             if (fsetxattr(tfd, "X", "X", 1, XATTR_CREATE) != 0) {
the name needs to be namespace prefixed, so that would be:
    fsetxattr(tfd, "user.X", "X", ...);


cheers.

--
Nathan

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfsprogs: update doc/CHANGES

[Christoph Hellwig]

Thanks, I've pushed the xfsprogs updates now.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs