* [PATCH] xfs_io: fix comment in bmap.c
@ 2009-01-24 14:39 Christoph Hellwig
2009-01-24 15:10 ` Eric Sandeen
2009-01-24 17:59 ` Felix Blyakher
0 siblings, 2 replies; 3+ messages in thread
From: Christoph Hellwig @ 2009-01-24 14:39 UTC (permalink / raw)
To: xfs
Based on a patch from Tomasz Majkowski <moosh009@gmail.com> in bugzilla
#785.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: xfsprogs-dev/io/bmap.c
===================================================================
--- xfsprogs-dev.orig/io/bmap.c 2009-01-24 15:36:56.780113315 +0100
+++ xfsprogs-dev/io/bmap.c 2009-01-24 15:37:17.875168142 +0100
@@ -140,7 +140,7 @@ bmap_f(
}
}
- map_size = nflag ? nflag+2 : 32; /* initial guess - 256 */
+ map_size = nflag ? nflag+2 : 32; /* initial guess - 32 */
map = malloc(map_size*sizeof(*map));
if (map == NULL) {
fprintf(stderr, _("%s: malloc of %d bytes failed.\n"),
@@ -151,7 +151,7 @@ bmap_f(
/* Try the xfsctl(XFS_IOC_GETBMAPX) for the number of extents specified
- * by nflag, or the initial guess number of extents (256).
+ * by nflag, or the initial guess number of extents (32).
*
* If there are more extents than we guessed, use xfsctl
* (XFS_IOC_FSGETXATTR[A]) to get the extent count, realloc some more
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xfs_io: fix comment in bmap.c
2009-01-24 14:39 [PATCH] xfs_io: fix comment in bmap.c Christoph Hellwig
@ 2009-01-24 15:10 ` Eric Sandeen
2009-01-24 17:59 ` Felix Blyakher
1 sibling, 0 replies; 3+ messages in thread
From: Eric Sandeen @ 2009-01-24 15:10 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: xfs
Christoph Hellwig wrote:
> Based on a patch from Tomasz Majkowski <moosh009@gmail.com> in bugzilla
> #785.
>
Heh, I can ACK this one :)
-Eric
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Index: xfsprogs-dev/io/bmap.c
> ===================================================================
> --- xfsprogs-dev.orig/io/bmap.c 2009-01-24 15:36:56.780113315 +0100
> +++ xfsprogs-dev/io/bmap.c 2009-01-24 15:37:17.875168142 +0100
> @@ -140,7 +140,7 @@ bmap_f(
> }
> }
>
> - map_size = nflag ? nflag+2 : 32; /* initial guess - 256 */
> + map_size = nflag ? nflag+2 : 32; /* initial guess - 32 */
> map = malloc(map_size*sizeof(*map));
> if (map == NULL) {
> fprintf(stderr, _("%s: malloc of %d bytes failed.\n"),
> @@ -151,7 +151,7 @@ bmap_f(
>
>
> /* Try the xfsctl(XFS_IOC_GETBMAPX) for the number of extents specified
> - * by nflag, or the initial guess number of extents (256).
> + * by nflag, or the initial guess number of extents (32).
> *
> * If there are more extents than we guessed, use xfsctl
> * (XFS_IOC_FSGETXATTR[A]) to get the extent count, realloc some more
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xfs_io: fix comment in bmap.c
2009-01-24 14:39 [PATCH] xfs_io: fix comment in bmap.c Christoph Hellwig
2009-01-24 15:10 ` Eric Sandeen
@ 2009-01-24 17:59 ` Felix Blyakher
1 sibling, 0 replies; 3+ messages in thread
From: Felix Blyakher @ 2009-01-24 17:59 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: xfs
On Jan 24, 2009, at 8:39 AM, Christoph Hellwig wrote:
> Based on a patch from Tomasz Majkowski <moosh009@gmail.com> in
> bugzilla
> #785.
Easy one, make comments reflect the code.
Looks good.
Felix
>
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Index: xfsprogs-dev/io/bmap.c
> ===================================================================
> --- xfsprogs-dev.orig/io/bmap.c 2009-01-24 15:36:56.780113315 +0100
> +++ xfsprogs-dev/io/bmap.c 2009-01-24 15:37:17.875168142 +0100
> @@ -140,7 +140,7 @@ bmap_f(
> }
> }
>
> - map_size = nflag ? nflag+2 : 32; /* initial guess - 256 */
> + map_size = nflag ? nflag+2 : 32; /* initial guess - 32 */
> map = malloc(map_size*sizeof(*map));
> if (map == NULL) {
> fprintf(stderr, _("%s: malloc of %d bytes failed.\n"),
> @@ -151,7 +151,7 @@ bmap_f(
>
>
> /* Try the xfsctl(XFS_IOC_GETBMAPX) for the number of extents
> specified
> - * by nflag, or the initial guess number of extents (256).
> + * by nflag, or the initial guess number of extents (32).
> *
> * If there are more extents than we guessed, use xfsctl
> * (XFS_IOC_FSGETXATTR[A]) to get the extent count, realloc some more
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-01-24 18:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-24 14:39 [PATCH] xfs_io: fix comment in bmap.c Christoph Hellwig
2009-01-24 15:10 ` Eric Sandeen
2009-01-24 17:59 ` Felix Blyakher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox