From: "Josef 'Jeff' Sipek" <jeffpc@josefsipek.net>
To: Christoph Hellwig <hch@lst.de>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs_admin: exit gracefully for non-XFS fileststems
Date: Sun, 25 Jan 2009 00:56:18 -0500 [thread overview]
Message-ID: <20090125055618.GM5587@josefsipek.net> (raw)
In-Reply-To: <20090125050342.GA30091@lst.de>
On Sun, Jan 25, 2009 at 06:03:42AM +0100, Christoph Hellwig wrote:
> Exit gracefully if the magic number doesn't match xfs in xfs_admin
> and xfs_ncheck. This is implemented by a new -C option to xfs_db
> which makes it exit with a useful error message in case the filesystem
> doesn't match the XFS superblock magic number.
>
>
> Reported-by: Dick Middleton <dick@lingbrae.com>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
...
> Index: xfsprogs-dev/man/man8/xfs_db.8
> ===================================================================
> --- xfsprogs-dev.orig/man/man8/xfs_db.8 2009-01-24 19:15:16.855428751 +0100
> +++ xfsprogs-dev/man/man8/xfs_db.8 2009-01-24 19:17:21.689554003 +0100
...
> @@ -32,6 +34,10 @@ that run
> .PP
> .SH OPTIONS
> .TP
> +.B \-C
> +Check the superblock magic number and exit gracefully if the filesystem is not
> +an XFS filesystem.
Obviously, the 'C' is supposed to stand for "check". I think that's
misleading. xfs_db _always_ checks the SB magic. This option just changes
the the behavior on a mis-match. In a way, I think this flag belongs into
the "verbose/quiet" category. It really is
--you-really-want-to-work-with-xfs-volumes-only...I guess it's a don't-force
flag.
I can't think of a good letter for it at the moment.
Josef 'Jeff' Sipek.
--
Hegh QaQ law'
quvHa'ghach QaQ puS
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-01-25 5:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-25 5:03 [PATCH] xfs_admin: exit gracefully for non-XFS fileststems Christoph Hellwig
2009-01-25 5:56 ` Josef 'Jeff' Sipek [this message]
2009-01-29 21:43 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090125055618.GM5587@josefsipek.net \
--to=jeffpc@josefsipek.net \
--cc=hch@lst.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox