From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
Andrew Morton <akpm@linux-foundation.org>,
pm@debian.org, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] don't reallocate sxp variable passed into xfs_swapext
Date: Mon, 26 Jan 2009 02:46:36 -0500 [thread overview]
Message-ID: <20090126074636.GB27188@infradead.org> (raw)
In-Reply-To: <497D258C.1000908@sandeen.net>
On Sun, Jan 25, 2009 at 08:53:00PM -0600, Eric Sandeen wrote:
> fixes kernel.org bugzilla 12538, xfs_fsr fails on 2.6.29-rc kernels
>
> Regression caused by 743bb4650da9e2595d6cedd01c680b5b9398c74a
>
> This was an embarrasing mistake, reallocating the sxp pointer passed
> in from the main ioctl switch.
>
> Signed-off-by: Eric Sandeen <sandeen@sandeen.net
> Reported-by: Paul Martin <pm@debian.org>
> Tested-by: Paul Martin <pm@debian.org>
Yikes. Looks good to me, but any chance you could try cooking up a
xfsqa test that would hit this as our existing xfs_fsr test apparently
doesn't?
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2009-01-26 7:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-26 2:53 [PATCH] don't reallocate sxp variable passed into xfs_swapext Eric Sandeen
2009-01-26 3:14 ` Felix Blyakher
2009-01-26 7:46 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090126074636.GB27188@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=pm@debian.org \
--cc=rjw@sisk.pl \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox