From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <xfs-bounces@oss.sgi.com>
Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15])
	by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id
	n0TMbgSk238699 for <xfs@oss.sgi.com>; Thu, 29 Jan 2009 16:37:42 -0600
Received: from bombadil.infradead.org (localhost [127.0.0.1])
	by cuda.sgi.com (Spam Firewall) with ESMTP id 344C718890CE
	for <xfs@oss.sgi.com>; Thu, 29 Jan 2009 14:37:01 -0800 (PST)
Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34])
	by cuda.sgi.com with ESMTP id 7ozUfTY0pxVAbg8G for
	<xfs@oss.sgi.com>; Thu, 29 Jan 2009 14:37:01 -0800 (PST)
Date: Thu, 29 Jan 2009 17:37:00 -0500
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH] remove remaining unused-but-installed headers
Message-ID: <20090129223700.GA3772@infradead.org>
References: <1233141843.4584.40.camel@verge.scott.net.au>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <1233141843.4584.40.camel@verge.scott.net.au>
List-Id: XFS Filesystem from SGI <xfs.oss.sgi.com>
List-Unsubscribe: <http://oss.sgi.com/mailman/options/xfs>,
	<mailto:xfs-request@oss.sgi.com?subject=unsubscribe>
List-Archive: <http://oss.sgi.com/pipermail/xfs>
List-Post: <mailto:xfs@oss.sgi.com>
List-Help: <mailto:xfs-request@oss.sgi.com?subject=help>
List-Subscribe: <http://oss.sgi.com/mailman/listinfo/xfs>,
	<mailto:xfs-request@oss.sgi.com?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: xfs-bounces@oss.sgi.com
Errors-To: xfs-bounces@oss.sgi.com
To: Nathan Scott <nscott@aconex.com>
Cc: xfs@oss.sgi.com

On Wed, Jan 28, 2009 at 10:24:03PM +1100, Nathan Scott wrote:
> diff --git a/include/Makefile b/include/Makefile
> index 0403536..07076cc 100644
> --- a/include/Makefile
> +++ b/include/Makefile
> @@ -29,9 +29,9 @@ QAHFILES = libxfs.h libxlog.h \
>  	xfs_imap.h xfs_inode.h xfs_inode_item.h xfs_inum.h \
>  	xfs_log.h xfs_log_priv.h xfs_log_recover.h xfs_metadump.h \
>  	xfs_mount.h xfs_quota.h xfs_rtalloc.h xfs_sb.h \
> -	xfs_trans.h xfs_trans_space.h xfs_types.h
> +	xfs_trans.h xfs_trans_space.h xfs_types.h xfs_dfrag.h

dfrag is not needed anymore because we moved fsr to xfsprogs.

> -	$(INSTALL) -m 755 -d $(DK_INC_DIR)
> -	$(INSTALL) -m 644 $(DKHFILES) $(DK_INC_DIR)

I think as some point libdisk was supposed to be a library others
could use.  I don't mind if we make it private as it should be fold
into the libvolume_id/libblkid successor in util-linux one day.


So all over this look good to me.

Reviewed-by: Christoph Hellwig <hch@lst.de>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs