From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n0V0e9Sg062181 for ; Fri, 30 Jan 2009 18:40:10 -0600 From: Arnd Bergmann Subject: Re: [PATCH] fs: Add new pre-allocation ioctls to vfs for compatibility with legacy xfs ioctls Date: Sat, 31 Jan 2009 01:38:32 +0100 References: <4980C71F.1010804@ankitjain.org> <20090130162252.7bf9c1f4.akpm@linux-foundation.org> In-Reply-To: <20090130162252.7bf9c1f4.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Disposition: inline Message-Id: <200901310138.34164.arnd@arndb.de> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Andrew Morton Cc: mfasheh@suse.com, joel.becker@oracle.com, linux-kernel@vger.kernel.org, hch@infradead.org, xfs-masters@oss.sgi.com, viro@zeniv.linux.org.uk, Ankit Jain , linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com, ocfs2-devel@oss.oracle.com On Saturday 31 January 2009, Andrew Morton wrote: > On Thu, 29 Jan 2009 02:29:11 +0530 Ankit Jain wrote: > > +struct space_resv { > > + __s16 l_type; > > + __s16 l_whence; > > + __s64 l_start; > > + __s64 l_len; /* len == 0 means until end of file */ > > + __s32 l_sysid; > > + __u32 l_pid; > > + __s32 l_pad[4]; /* reserve area */ > > +}; > > + > > +#define F_IOC_RESVSP _IOW('X', 40, struct space_resv) > > +#define F_IOC_RESVSP64 _IOW('X', 42, struct space_resv) > > Are we sure that the aligment of l_start will be reliably the same > across all compilers and versions thereof for all time? On x86, the alignment differs between 32 and 64 bit, otherwise it's ok. XFS handles the conversion for compat_ioctl in fs/xfs/linux-2.6/xfs_ioctl32.c. If this becomes a generic file ioctl, the conversion code should be moved to fs/compat_ioctl.c. Arnd <>< _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs