From: Christoph Hellwig <hch@infradead.org>
To: Christoph Hellwig <hch@infradead.org>,
Nick Piggin <nickpiggin@yahoo.com.au>,
xfs@oss.sgi.com
Subject: Re: reproducible xfs/vmap oops
Date: Tue, 3 Feb 2009 17:08:09 -0500 [thread overview]
Message-ID: <20090203220808.GA9195@infradead.org> (raw)
In-Reply-To: <20090203214711.GA24837@infradead.org>
On Tue, Feb 03, 2009 at 04:47:11PM -0500, Christoph Hellwig wrote:
> On Wed, Feb 04, 2009 at 08:42:45AM +1100, Dave Chinner wrote:
> > On Tue, Feb 03, 2009 at 04:04:23PM -0500, Christoph Hellwig wrote:
> > > [ 3138.799436] XFS mounting filesystem vde
> > > [ 3138.813184] va->va_start = 4290777088, va->va_end = 4096
> > > [ 3138.834754] tmp->va_start = 4195352576, tmp->va_end = 4196401152
> > > [ 3138.846352] ------------[ cut here ]------------
> > > [ 3138.850332] kernel BUG at mm/vmalloc.c:298!
> > > [ 3138.850332] invalid opcode: 0000 [#1] SMP
> > >
> > > The first va_end looks suspicious to me..
> >
> > That is on i386, Christoph? If so, I'd suspect a 32 bit overflow
> > as 4290777088 = 0xFFC01000 and va_start/va_end are unsigned longs.
> > If we tried to map exactly 4MB the with va_start at 0xFFC01000 we'd
> > end up with va_end at 0x100001000 which would wrap to 0x1000 = 4096.
>
> Yeah, this is 32-bit x86. Exactly my thoughts, but just to make sure
> the overflow is in vmap and not in XFS I'm running with your checking
> patch included now.
Nope, your check doesn't trigger. Looks like it's indeed in vmap.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-02-03 22:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-01 8:12 reproducible xfs/vmap oops Christoph Hellwig
2009-02-01 16:14 ` Christoph Hellwig
2009-02-03 15:51 ` Christoph Hellwig
[not found] ` <200902040303.13933.nickpiggin@yahoo.com.au>
2009-02-03 16:05 ` Christoph Hellwig
2009-02-03 18:44 ` Christoph Hellwig
2009-02-03 21:04 ` Christoph Hellwig
2009-02-03 21:42 ` Dave Chinner
2009-02-03 21:47 ` Christoph Hellwig
2009-02-03 22:08 ` Christoph Hellwig [this message]
[not found] ` <200902041648.55603.nickpiggin@yahoo.com.au>
2009-02-04 8:15 ` Christoph Hellwig
2009-02-04 8:30 ` Christoph Hellwig
[not found] ` <200902042027.40762.nickpiggin@yahoo.com.au>
2009-02-04 19:38 ` Christoph Hellwig
[not found] ` <200902101543.15988.nickpiggin@yahoo.com.au>
2009-02-10 7:54 ` Christoph Hellwig
2009-02-15 19:15 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090203220808.GA9195@infradead.org \
--to=hch@infradead.org \
--cc=nickpiggin@yahoo.com.au \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox