From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: xfs_db: fix wrong sibling pointers offset for the bmbt attr block
Date: Mon, 9 Feb 2009 13:11:36 +1100 [thread overview]
Message-ID: <20090209021136.GC8830@disturbed> (raw)
In-Reply-To: <20090208211515.GB22118@infradead.org>
On Sun, Feb 08, 2009 at 04:15:15PM -0500, Christoph Hellwig wrote:
> The attr bmbt should use long, not short pointers.
>
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Index: xfsprogs-dev/db/btblock.c
> ===================================================================
> --- xfsprogs-dev.orig/db/btblock.c 2009-02-08 22:13:05.225944103 +0100
> +++ xfsprogs-dev/db/btblock.c 2009-02-08 22:13:14.143944165 +0100
> @@ -227,8 +227,8 @@ const field_t bmapbtd_flds[] = {
> { "magic", FLDT_UINT32X, OI(OFF(magic)), C1, 0, TYP_NONE },
> { "level", FLDT_UINT16D, OI(OFF(level)), C1, 0, TYP_NONE },
> { "numrecs", FLDT_UINT16D, OI(OFF(numrecs)), C1, 0, TYP_NONE },
> - { "leftsib", FLDT_DFSBNO, OI(OFF(u.s.bb_leftsib)), C1, 0, TYP_BMAPBTD },
> - { "rightsib", FLDT_DFSBNO, OI(OFF(u.s.bb_rightsib)), C1, 0, TYP_BMAPBTD },
> + { "leftsib", FLDT_DFSBNO, OI(OFF(u.l.bb_leftsib)), C1, 0, TYP_BMAPBTD },
> + { "rightsib", FLDT_DFSBNO, OI(OFF(u.l.bb_rightsib)), C1, 0, TYP_BMAPBTD },
> { "recs", FLDT_BMAPBTDREC, btblock_rec_offset, btblock_rec_count,
> FLD_ARRAY|FLD_ABASE1|FLD_COUNT|FLD_OFFSET, TYP_NONE },
> { "keys", FLDT_BMAPBTDKEY, btblock_key_offset, btblock_key_count,
Reviewed-by: Dave Chinner <david@fromorbit.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2009-02-09 2:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-08 21:15 xfs_db: fix wrong sibling pointers offset for the bmbt attr block Christoph Hellwig
2009-02-09 2:11 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090209021136.GC8830@disturbed \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox