* xfs_db: fix wrong sibling pointers offset for the bmbt attr block
@ 2009-02-08 21:15 Christoph Hellwig
2009-02-09 2:11 ` Dave Chinner
0 siblings, 1 reply; 2+ messages in thread
From: Christoph Hellwig @ 2009-02-08 21:15 UTC (permalink / raw)
To: xfs
The attr bmbt should use long, not short pointers.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: xfsprogs-dev/db/btblock.c
===================================================================
--- xfsprogs-dev.orig/db/btblock.c 2009-02-08 22:13:05.225944103 +0100
+++ xfsprogs-dev/db/btblock.c 2009-02-08 22:13:14.143944165 +0100
@@ -227,8 +227,8 @@ const field_t bmapbtd_flds[] = {
{ "magic", FLDT_UINT32X, OI(OFF(magic)), C1, 0, TYP_NONE },
{ "level", FLDT_UINT16D, OI(OFF(level)), C1, 0, TYP_NONE },
{ "numrecs", FLDT_UINT16D, OI(OFF(numrecs)), C1, 0, TYP_NONE },
- { "leftsib", FLDT_DFSBNO, OI(OFF(u.s.bb_leftsib)), C1, 0, TYP_BMAPBTD },
- { "rightsib", FLDT_DFSBNO, OI(OFF(u.s.bb_rightsib)), C1, 0, TYP_BMAPBTD },
+ { "leftsib", FLDT_DFSBNO, OI(OFF(u.l.bb_leftsib)), C1, 0, TYP_BMAPBTD },
+ { "rightsib", FLDT_DFSBNO, OI(OFF(u.l.bb_rightsib)), C1, 0, TYP_BMAPBTD },
{ "recs", FLDT_BMAPBTDREC, btblock_rec_offset, btblock_rec_count,
FLD_ARRAY|FLD_ABASE1|FLD_COUNT|FLD_OFFSET, TYP_NONE },
{ "keys", FLDT_BMAPBTDKEY, btblock_key_offset, btblock_key_count,
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: xfs_db: fix wrong sibling pointers offset for the bmbt attr block
2009-02-08 21:15 xfs_db: fix wrong sibling pointers offset for the bmbt attr block Christoph Hellwig
@ 2009-02-09 2:11 ` Dave Chinner
0 siblings, 0 replies; 2+ messages in thread
From: Dave Chinner @ 2009-02-09 2:11 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: xfs
On Sun, Feb 08, 2009 at 04:15:15PM -0500, Christoph Hellwig wrote:
> The attr bmbt should use long, not short pointers.
>
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Index: xfsprogs-dev/db/btblock.c
> ===================================================================
> --- xfsprogs-dev.orig/db/btblock.c 2009-02-08 22:13:05.225944103 +0100
> +++ xfsprogs-dev/db/btblock.c 2009-02-08 22:13:14.143944165 +0100
> @@ -227,8 +227,8 @@ const field_t bmapbtd_flds[] = {
> { "magic", FLDT_UINT32X, OI(OFF(magic)), C1, 0, TYP_NONE },
> { "level", FLDT_UINT16D, OI(OFF(level)), C1, 0, TYP_NONE },
> { "numrecs", FLDT_UINT16D, OI(OFF(numrecs)), C1, 0, TYP_NONE },
> - { "leftsib", FLDT_DFSBNO, OI(OFF(u.s.bb_leftsib)), C1, 0, TYP_BMAPBTD },
> - { "rightsib", FLDT_DFSBNO, OI(OFF(u.s.bb_rightsib)), C1, 0, TYP_BMAPBTD },
> + { "leftsib", FLDT_DFSBNO, OI(OFF(u.l.bb_leftsib)), C1, 0, TYP_BMAPBTD },
> + { "rightsib", FLDT_DFSBNO, OI(OFF(u.l.bb_rightsib)), C1, 0, TYP_BMAPBTD },
> { "recs", FLDT_BMAPBTDREC, btblock_rec_offset, btblock_rec_count,
> FLD_ARRAY|FLD_ABASE1|FLD_COUNT|FLD_OFFSET, TYP_NONE },
> { "keys", FLDT_BMAPBTDKEY, btblock_key_offset, btblock_key_count,
Reviewed-by: Dave Chinner <david@fromorbit.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-02-09 2:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-08 21:15 xfs_db: fix wrong sibling pointers offset for the bmbt attr block Christoph Hellwig
2009-02-09 2:11 ` Dave Chinner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox