From: Dave Chinner <david@fromorbit.com>
To: Lachlan McIlroy <lachlan@sgi.com>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] Re-dirty pages on I/O error
Date: Tue, 10 Feb 2009 21:01:29 +1100 [thread overview]
Message-ID: <20090210100129.GN8830@disturbed> (raw)
In-Reply-To: <4990DCF6.5000900@sgi.com>
On Tue, Feb 10, 2009 at 12:48:38PM +1100, Lachlan McIlroy wrote:
> [This patch seems to have slipped through the proverbial crack.]
>
> If we get an error in xfs_page_state_convert() - and it's not EAGAIN - then
> we throw away the dirty page without converting the delayed allocation. This
> leaves delayed allocations that can never be removed and confuses code that
> expects a flush of the file to clear them. We need to re-dirty the page on
> error so we can try again later or report that the flush failed.
As discussed previously, the fix that is needed in the page
invalidation path. i.e. the page invalidate path clears the
buffer_delay() flag (via discard_buffer) before we get to
->releasepage and so releasepage fails to convert the delalloc
extent before tossing the page....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-02-10 10:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-10 1:48 [PATCH] Re-dirty pages on I/O error Lachlan McIlroy
2009-02-10 10:01 ` Dave Chinner [this message]
2009-02-10 23:33 ` Lachlan McIlroy
2009-02-15 20:05 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2008-09-11 8:37 Lachlan McIlroy
2008-09-11 10:33 ` Christoph Hellwig
2008-09-11 21:21 ` Eric Sandeen
2008-09-12 6:44 ` Lachlan McIlroy
2008-09-12 13:17 ` Eric Sandeen
2008-09-12 6:04 ` Lachlan McIlroy
2008-09-13 4:19 ` Dave Chinner
2008-09-15 3:22 ` Lachlan McIlroy
2008-09-16 4:01 ` Dave Chinner
2008-09-16 6:30 ` Lachlan McIlroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090210100129.GN8830@disturbed \
--to=david@fromorbit.com \
--cc=lachlan@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox