From: Dave Chinner <david@fromorbit.com>
To: Lachlan McIlroy <lachlan@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] Check if AIL has been started before stopping it
Date: Tue, 10 Feb 2009 21:12:59 +1100 [thread overview]
Message-ID: <20090210101259.GO8830@disturbed> (raw)
In-Reply-To: <4990D7EA.7020902@sgi.com>
On Tue, Feb 10, 2009 at 12:27:06PM +1100, Lachlan McIlroy wrote:
> A failure during mount can result in shutting down the AIL when
> it may not have been started up yet.
The ail init/destroy are supposed to be called symmetrically. if the
destroy is being called when the init has not been run or completed,
then the bug is at the caller.
Reading between the lines of your brief description of the problem,
xfs_trans_ail_init() has failed with ENOMEM, and that has called
xfs_trans_ail_destroy() erroneously. The correct fix is to call
xlog_dealloc_log() when xfs_trans_ail_init() fails, not
xfs_log_unmount_dealloc() which calls xfs_trans_ail_destroy() before
calling xlog_dealloc_log().
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2009-02-10 10:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-10 1:27 [PATCH] Check if AIL has been started before stopping it Lachlan McIlroy
2009-02-10 10:12 ` Christoph Hellwig
2009-02-10 10:12 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090210101259.GO8830@disturbed \
--to=david@fromorbit.com \
--cc=lachlan@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox