why does mkfs.xfs complain here?

why does mkfs.xfs complain here?

[Michael Monnerie]

# mkfs.xfs -f -L ws1phptmp -b size=4096 -d su=65536,sw=4,agcount=4 -i attr=2 -l lazy-count=1,su=65536 /dev/sdf1
log stripe unit specified, using v2 logs
Allocation group size (65262) is not a multiple of the stripe unit (16)

Why is above error generated at all? Shouldn't mkfs.xfs handle that 
situation and change agsize automatically? If I then do:

# mkfs.xfs -f -L ws1phptmp -b size=4096 -d su=64k,sw=4,agsize=65262b -i attr=2 -l lazy-count=1,su=65536 /dev/sdf1
log stripe unit specified, using v2 logs
agsize rounded to 65264, swidth = 64
meta-data=/dev/sdf1              isize=256    agcount=4, agsize=65264 blks
         =                       sectsz=512   attr=2
data     =                       bsize=4096   blocks=261048, imaxpct=25
         =                       sunit=16     swidth=64 blks, unwritten=1
naming   =version 2              bsize=4096
log      =internal log           bsize=4096   blocks=1200, version=2
         =                       sectsz=512   sunit=16 blks, lazy-count=1
realtime =none                   extsz=4096   blocks=0, rtextents=0

So no problem using agsize instead agcount, where agcount complained
about group size = 65262, which I then used without problem?

mfg zmi
-- 
// Michael Monnerie, Ing.BSc    -----      http://it-management.at
// Tel: 0660 / 415 65 31                      .network.your.ideas.
// PGP Key:         "curl -s http://zmi.at/zmi.asc | gpg --import"
// Fingerprint: AC19 F9D5 36ED CD8A EF38  500E CE14 91F7 1C12 09B4
// Keyserver: wwwkeys.eu.pgp.net                  Key-ID: 1C1209B4

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: why does mkfs.xfs complain here?

[Eric Sandeen]

Michael Monnerie wrote:
> # mkfs.xfs -f -L ws1phptmp -b size=4096 -d su=65536,sw=4,agcount=4 -i attr=2 -l lazy-count=1,su=65536 /dev/sdf1
> log stripe unit specified, using v2 logs
> Allocation group size (65262) is not a multiple of the stripe unit (16)
>
> Why is above error generated at all? Shouldn't mkfs.xfs handle that 
> situation and change agsize automatically? 

Well, you constrained it fairly well. But I suppose this is a bug.

> If I then do:
> 
> # mkfs.xfs -f -L ws1phptmp -b size=4096 -d su=64k,sw=4,agsize=65262b -i attr=2 -l lazy-count=1,su=65536 /dev/sdf1
> log stripe unit specified, using v2 logs
> agsize rounded to 65264, swidth = 64
> meta-data=/dev/sdf1              isize=256    agcount=4, agsize=65264 blks
>          =                       sectsz=512   attr=2
> data     =                       bsize=4096   blocks=261048, imaxpct=25
>          =                       sunit=16     swidth=64 blks, unwritten=1
> naming   =version 2              bsize=4096
> log      =internal log           bsize=4096   blocks=1200, version=2
>          =                       sectsz=512   sunit=16 blks, lazy-count=1
> realtime =none                   extsz=4096   blocks=0, rtextents=0
> 
> So no problem using agsize instead agcount, where agcount complained
> about group size = 65262, which I then used without problem?

and then it chose 65264 instead.

all this is a little messy in mkfs.xfs, I suppose you've found a bug....

-Eric

> mfg zmi

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: why does mkfs.xfs complain here?

[Michael Monnerie]

On Mittwoch 11 Februar 2009 Eric Sandeen wrote:
> > # mkfs.xfs -f -L ws1phptmp -b size=4096 -d
> > su=64k,sw=4,agsize=65262b -i attr=2 -l lazy-count=1,su=65536
> > /dev/sdf1 log stripe unit specified, using v2 logs
> > agsize rounded to 65264, swidth = 64
> > meta-data=/dev/sdf1              isize=256    agcount=4,
> > agsize=65264 blks =                       sectsz=512   attr=2
> > data     =                       bsize=4096   blocks=261048,
> > imaxpct=25 =                       sunit=16     swidth=64 blks,
> > unwritten=1 naming   =version 2              bsize=4096
> > log      =internal log           bsize=4096   blocks=1200,
> > version=2 =                       sectsz=512   sunit=16 blks,
> > lazy-count=1 realtime =none                   extsz=4096  
> > blocks=0, rtextents=0
> >
> > So no problem using agsize instead agcount, where agcount
> > complained about group size = 65262, which I then used without
> > problem?
>
> and then it chose 65264 instead.
>
> all this is a little messy in mkfs.xfs, I suppose you've found a
> bug....

Good, I wasn't sure if it's me not understanding it. :-)
Also, the line
agsize rounded to 65264, swidth = 64
should be changed to use units:
agsize rounded to 65264b, swidth = 64k
and so should all other values also I guess. It would be good at least, 
as the current mixture is confusing:
imaxpct=25 =                       sunit=16     swidth=64 blks,
The "pct" is clear, but could have "%", swidth has the units "blks", but 
what is "sunit" is only clear if you read the man page.

Yes, somewhat messy, maybe there can be a full cleanup. :-)

mfg zmi
-- 
// Michael Monnerie, Ing.BSc    -----      http://it-management.at
// Tel: 0660 / 415 65 31                      .network.your.ideas.
// PGP Key:         "curl -s http://zmi.at/zmi.asc | gpg --import"
// Fingerprint: AC19 F9D5 36ED CD8A EF38  500E CE14 91F7 1C12 09B4
// Keyserver: wwwkeys.eu.pgp.net                  Key-ID: 1C1209B4

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs