public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Michael Monnerie <michael.monnerie@is.it-management.at>
To: xfs@oss.sgi.com
Subject: Re: why does mkfs.xfs complain here?
Date: Wed, 11 Feb 2009 15:13:00 +0100	[thread overview]
Message-ID: <200902111513.00473@zmi.at> (raw)
In-Reply-To: <4992D3B7.7060101@sandeen.net>

On Mittwoch 11 Februar 2009 Eric Sandeen wrote:
> > # mkfs.xfs -f -L ws1phptmp -b size=4096 -d
> > su=64k,sw=4,agsize=65262b -i attr=2 -l lazy-count=1,su=65536
> > /dev/sdf1 log stripe unit specified, using v2 logs
> > agsize rounded to 65264, swidth = 64
> > meta-data=/dev/sdf1              isize=256    agcount=4,
> > agsize=65264 blks =                       sectsz=512   attr=2
> > data     =                       bsize=4096   blocks=261048,
> > imaxpct=25 =                       sunit=16     swidth=64 blks,
> > unwritten=1 naming   =version 2              bsize=4096
> > log      =internal log           bsize=4096   blocks=1200,
> > version=2 =                       sectsz=512   sunit=16 blks,
> > lazy-count=1 realtime =none                   extsz=4096  
> > blocks=0, rtextents=0
> >
> > So no problem using agsize instead agcount, where agcount
> > complained about group size = 65262, which I then used without
> > problem?
>
> and then it chose 65264 instead.
>
> all this is a little messy in mkfs.xfs, I suppose you've found a
> bug....

Good, I wasn't sure if it's me not understanding it. :-)
Also, the line
agsize rounded to 65264, swidth = 64
should be changed to use units:
agsize rounded to 65264b, swidth = 64k
and so should all other values also I guess. It would be good at least, 
as the current mixture is confusing:
imaxpct=25 =                       sunit=16     swidth=64 blks,
The "pct" is clear, but could have "%", swidth has the units "blks", but 
what is "sunit" is only clear if you read the man page.

Yes, somewhat messy, maybe there can be a full cleanup. :-)

mfg zmi
-- 
// Michael Monnerie, Ing.BSc    -----      http://it-management.at
// Tel: 0660 / 415 65 31                      .network.your.ideas.
// PGP Key:         "curl -s http://zmi.at/zmi.asc | gpg --import"
// Fingerprint: AC19 F9D5 36ED CD8A EF38  500E CE14 91F7 1C12 09B4
// Keyserver: wwwkeys.eu.pgp.net                  Key-ID: 1C1209B4

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      reply	other threads:[~2009-02-11 14:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-11 12:10 why does mkfs.xfs complain here? Michael Monnerie
2009-02-11 13:33 ` Eric Sandeen
2009-02-11 14:13   ` Michael Monnerie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200902111513.00473@zmi.at \
    --to=michael.monnerie@is.it-management.at \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox