From: Christoph Hellwig <hch@infradead.org>
To: Lachlan McIlroy <lachlan@sgi.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH 1/2] xfs: fix error handling in xfs_log_mount
Date: Wed, 11 Feb 2009 17:39:23 -0500 [thread overview]
Message-ID: <20090211223923.GA25252@infradead.org> (raw)
In-Reply-To: <49920CB5.1020103@sgi.com>
On Wed, Feb 11, 2009 at 10:24:37AM +1100, Lachlan McIlroy wrote:
> I'd prefer both fixes go in so we have maximum defence against
> this problem happening again but I'm really not fussed.
I disagree. All these weird error checks for things that can't happen
just make the code big, bloated and unreadable. And they make people
sloppy by not enforcing the same unwind order thus leading to more
bugs (as seen by the historic xfs mount path before we started unwinding
it)
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-02-11 22:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-10 19:44 [PATCH 0/2] 2.6.29 queue Christoph Hellwig
2009-02-10 19:44 ` [PATCH 1/2] xfs: fix error handling in xfs_log_mount Christoph Hellwig
2009-02-10 19:56 ` Felix Blyakher
2009-02-10 19:57 ` Christoph Hellwig
2009-02-10 20:09 ` Felix Blyakher
2009-02-10 23:24 ` Lachlan McIlroy
2009-02-11 22:39 ` Christoph Hellwig [this message]
2009-02-10 19:44 ` [PATCH 2/2] xfs: reject swapext ioctl on swapfiles Christoph Hellwig
2009-02-10 20:00 ` Felix Blyakher
2009-02-12 19:19 ` [PATCH 0/2] 2.6.29 queue Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090211223923.GA25252@infradead.org \
--to=hch@infradead.org \
--cc=lachlan@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox